Mark some set_* fns as potentially throwing.

Make attributes marked `[SetterThrows]` use a `set_*` function that
returns a `Result`. Currently webidl only looks for a `[Throws]`
attribute.

Author: richard-uk1

crates/webidl/src/lib.rs

@@ -25,8 +25,9 @@ use crate::generator::{
 use crate::idl_type::ToIdlType;
 use crate::traverse::TraverseType;
 use crate::util::{
-    camel_case_ident, is_structural, is_type_unstable, read_dir, shouty_snake_case_ident,
-    snake_case_ident, throws, webidl_const_v_to_backend_const_v, TypePosition,
+    camel_case_ident, is_structural, is_type_unstable, read_dir, setter_throws,
+    shouty_snake_case_ident, snake_case_ident, throws, webidl_const_v_to_backend_const_v,
+    TypePosition,
 };
 use anyhow::Context;
 use anyhow::Result;
@@ -625,6 +626,7 @@ impl<'src> FirstPassRecord<'src> {
         let structural = is_structural(attrs.as_ref(), container_attrs);
 
         let catch = throws(attrs);
+        let setter_catch = setter_throws(attrs);
 
         let ty = type_
             .type_
@@ -659,7 +661,7 @@ impl<'src> FirstPassRecord<'src> {
                 attributes.push(InterfaceAttribute {
                     is_static,
                     structural,
-                    catch,
+                    catch: catch || setter_catch,
                     ty,
                     js_name,
                     kind,

crates/webidl/src/util.rs

@@ -611,6 +611,11 @@ pub fn throws(attrs: &Option<ExtendedAttributeList>) -> bool {
     has_named_attribute(attrs.as_ref(), "Throws")
 }
 
+/// Whether a webidl attribute is marked as throwing when setting.
+pub fn setter_throws(attrs: &Option<ExtendedAttributeList>) -> bool {
+    has_named_attribute(attrs.as_ref(), "SetterThrows")
+}
+
 fn flag_slices_immutable(ty: &mut IdlType) {
     match ty {
         IdlType::Int8Array { immutable }