Update to 4.0.0 agdk and switch to grafted android-games-sdk-rs repo #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are going to use a submodule so that it is easier to track and rebase our local changes onto new versions of android-games-sdk Signed-off-by: William Casarin <[email protected]>
|
going to update this to not use submodules, but to use a similar structure so that it maps nicer to the external repo. as per: It would be nice to have android-game-sdk-rs host on rust-mobile so that I can reference it in the docs in the subdir: |
jb55
changed the title
Also includes our patches on top (branch android-activity-2.0.2). This is mainly to test to make sure everything is still working. We will switch to the android-activity-4.0.0 branch when we're done Signed-off-by: William Casarin <[email protected]>
jb55
force-pushed
the
agdk-submodule
branch
2 times, most recently
from
fc9439c to
89600ed
Compare
Signed-off-by: William Casarin <[email protected]>
Signed-off-by: William Casarin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to:
This switches to an agdk submodule with our patches applied to both 4.0.0 and 2.0.2 for testing.
This compiles cleanly!
Things left to do
Fixes #185
Fixes #189
Fixes #188
Fixes #190
Fixes #186