Take review preferences into account when determining reviewers #1947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements step 6 of #1753. When
[assign.review_prefs]
is configured intriagebot.toml
, triagebot will now take into account the number of PRs already assigned to a reviewer, and their reviewer preferences.Users can set their review preferences by sending a DM to triagebot on Zulip, and sending
work set-pr-limit <max-prs>
(this was implemented in #1919). When a reviewer already hasN
PRs assigned whereN >= max-prs
, they will not be considered for assignment.Note that the way this is currently implemented, the assigned PR tracking only works for
rust-lang/rust
, so it should not be enabled on any other repo.There are a couple of questions in the design that we should consider (they do not necessarily block this PR though):
r? reviewer
) or when we use the adhoc group fallback assigment logic?CC @apiraino
Requesting a review regarding the implementation details, but I still want to discuss the design on Zulip first and update Forge, so marking as a draft for now. Best reviewer commit-by-commit. I should probably add more logging before we merge this.