Only consider PRs with certain labels to be in the reviewer workqueue #1952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it needs to use custom logic for determining if a PR is truly assigned to someone and waiting for a review.
PRs that do not pass this check will not be considered for the workqueue.
Urgau
reviewed
Apr 22, 2025
Kobzol
force-pushed
the
workqueue-pr-status
branch
from
6008fc1 to
3d96801
Compare
Urgau
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic for determining if a PR should be considered to be in the reviewer workqueue. The implemented rules are:
S-blocked,S-inactiveorrolluplabels.S-waiting-on-reviewlabel.This implementation is based on discussion in https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/New.20triagebot.20assignment.20logic.20respecting.20PR.20limits/with/513565237.
Prerequisite for #1947.