Update flamegraph and crox support #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for generating flamegraph and crox files from newer self-profile format, and remove support for old format. Fixes broken flamegraph and crox links on detailed query page for self-profile data in newer format. Breaks links for self-profile data in older format, for what it's worth.
|
Yeah I think it's been long enough now that the wrapping isn't really necessary and could also be added later if we really wanted to, ultimately, this seems good to merge for now. |
This was referenced Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for generating flamegraph and crox files from newer
self-profile format, and remove support for old format. Fixes broken
flamegraph and crox links on detailed query page for self-profile data
in newer format. Breaks links for self-profile data in older format,
for what it's worth.
Fixes #790. Fixes #851.