Skip to content

Downloading Profile Data From Detailed Query Page Fails with 500 #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rylev opened this issue Nov 2, 2020 · 3 comments · Fixed by #978
Closed

Downloading Profile Data From Detailed Query Page Fails with 500 #790

rylev opened this issue Nov 2, 2020 · 3 comments · Fixed by #978
Labels
A-api Issues related to the API exposed by the site C-bug A bug

Comments

@rylev
Copy link
Member

rylev commented Nov 2, 2020

Visiting a detailed query page and trying to download the profile data in some form other than "raw" fails with a 500.

To Reporduce

This does not seem to happen for all detailed query pages.

@lqd
Copy link
Member

lqd commented Nov 2, 2020

IIUC this is related to rustc's recent update of measureme, whose format is not compatible with the previous format. The analyzeme, crox and flamegraph tools currently used in rustc-perf are using the older format. The goal of PR #788 is to make it possible to use either versions depending on the format of the recorded profile.

Until that is completed, raw downloads still work (as they are not processed by the analyzeme tools) so you can, say, compute the flamegraph locally, but the flamegraph, crox json, and speedscope and FF profiler links on the detailed query pages won't work.

@Mark-Simulacrum
Copy link
Member

Yep, that's correct. I've been busy with other projects these last few weeks unfortunately so haven't found the time to focus on this, but hopefully that'll clear up soon.

@rylev rylev added C-bug A bug A-api Issues related to the API exposed by the site labels Jul 29, 2021
@tgnottingham
Copy link
Contributor

tgnottingham commented Aug 20, 2021

Fixed by #978. Technically doesn't support the old self-profile format, but that's probably not going to be an issue very often. If it becomes one, we can reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-api Issues related to the API exposed by the site C-bug A bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants