Skip to content

Revert compiletest new-executor, to re-land without download-rustc #140233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

Zalathar
Copy link
Contributor

Revert #139998 because the original merge triggered download-rustc, which messes with test metrics and prevents us from properly comparing them before/after the change.

The plan is to re-land this PR as-is, combined with a trivial compiler change to avoid download-rustc and get proper test metrics for comparison.

This reverts commit be181dd, reversing changes made to 645d0ad.

r? ghost

Revert <rust-lang#139998> because the original
merge triggered download-rustc, which messes with test metrics and prevents us
from properly comparing them before/after the change.

The plan is to re-land this PR as-is, combined with a trivial compiler change
to avoid download-rustc and get proper test metrics for comparison.

This reverts commit be181dd, reversing
changes made to 645d0ad.
@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 24, 2025

📌 Commit d0a4580 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Apr 24, 2025

Actually, let's not roll this up either in case it affects test diffs in a rollup (I don't expect that it does, but just in case). Giving this a higher priority to minimize number of merged PRs potentially affected (again, I don't expect differences but just to be extra safe).

@bors rollup=never p=5 (revert to previous libtest executor)

@bors
Copy link
Collaborator

bors commented Apr 24, 2025

⌛ Testing commit d0a4580 with merge 93fb0ed...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2025
…ouxu

Revert compiletest new-executor, to re-land without download-rustc

Revert <rust-lang#139998> because the original merge triggered download-rustc, which messes with test metrics and prevents us from properly comparing them before/after the change.

The plan is to re-land this PR as-is, combined with a trivial compiler change to avoid download-rustc and get proper test metrics for comparison.

This reverts commit be181dd, reversing changes made to 645d0ad.

r? ghost
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-mingw-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
---- [run-make] tests\run-make\amdgpu-kd stdout ----

error: rmake recipe failed to complete
status: exit code: 1
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake.exe"
stdout: none
--- stderr -------------------------------
command failed at line 18
Command { cmd: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "--crate-name" "foo" "--target=amdgcn-amd-amdhsa" "-Ctarget-cpu=gfx900" "--crate-type" "cdylib" "foo.rs", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe", defused: true, armed_location: Location { file: "D:\\a\\rust\\rust\\tests\\run-make\\amdgpu-kd\\rmake.rs", line: 12, col: 5 } }, already_executed: true }
output status: `exit code: 1`
=== STDOUT ===



=== STDERR ===
error: linking with `rust-lld` failed: exit code: 0xc0000374
  |
  = note: "rust-lld" "-flavor" "gnu" "--version-script=C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcIpimkr\\list" "--no-undefined-version" "<1 object files omitted>" "--as-needed" "-L" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcIpimkr\\raw-dylibs" "-Bdynamic" "--eh-frame-hdr" "-z" "noexecstack" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "-o" "foo.elf" "--gc-sections" "-shared"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: 

error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 279 passed; 1 failed; 110 ignored; 0 measured; 6 filtered out; finished in 209.64s

Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 2:32:12
make: *** [Makefile:124: ci-mingw-x] Error 1
  local time: Thu Apr 24 19:46:43 CUT 2025
  network time: Thu, 24 Apr 2025 19:46:43 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
Copy link
Collaborator

bors commented Apr 24, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2025
@jieyouxu
Copy link
Member

@bors retry rust-lld heap corruption

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2025
@jieyouxu jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. CI-spurious-fail-rust-lld-crash CI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruption and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 25, 2025
@jieyouxu jieyouxu self-assigned this Apr 25, 2025
@jieyouxu jieyouxu added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 25, 2025
…ouxu

Revert compiletest new-executor, to re-land without download-rustc

Revert <rust-lang#139998> because the original merge triggered download-rustc, which messes with test metrics and prevents us from properly comparing them before/after the change.

The plan is to re-land this PR as-is, combined with a trivial compiler change to avoid download-rustc and get proper test metrics for comparison.

This reverts commit be181dd, reversing changes made to 645d0ad.

r? ghost
@bors
Copy link
Collaborator

bors commented Apr 25, 2025

⌛ Testing commit d0a4580 with merge d4fe40a...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
failures:

---- [assembly] tests\assembly\targets\targets-elf.rs#armeb_unknown_linux_gnueabi stdout ----

error in revision `armeb_unknown_linux_gnueabi`: auxiliary build of D:\a\rust\rust\tests\auxiliary\minicore.rs failed to compile: 
status: exit code: 1
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\bin;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\bin\HostX64\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\bin\HostX64\x64;D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0-bootstrap-tools\x86_64-pc-windows-msvc\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Users\runneradmin\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\7.0\bin;C:\vcpkg;C:\tools\zstd;C:\hostedtoolcache\windows\stack\3.5.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\usr\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.23.8\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.3.8\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\17.0.15-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files\dotnet;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\mongosh;C:\Program Files\LLVM\bin;C:\Program Files (x86)\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\bin\HostX64\x64" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2" "--cfg" "armeb_unknown_linux_gnueabi" "--check-cfg" "cfg(test,FALSE,aarch64_be_unknown_linux_gnu,aarch64_be_unknown_linux_gnu_ilp32,aarch64_be_unknown_netbsd,aarch64_kmc_solid_asp3,aarch64_linux_android,aarch64_nintendo_switch_freestanding,aarch64_unknown_freebsd,aarch64_unknown_fuchsia,aarch64_unknown_hermit,aarch64_unknown_illumos,aarch64_unknown_linux_gnu,aarch64_unknown_linux_gnu_ilp32,aarch64_unknown_linux_musl,aarch64_unknown_linux_ohos,aarch64_unknown_netbsd,aarch64_unknown_none,aarch64_unknown_none_softfloat,aarch64_unknown_nto_qnx700,aarch64_unknown_nto_qnx710,aarch64_unknown_nto_qnx710_iosock,aarch64_unknown_nto_qnx800,aarch64_unknown_openbsd,aarch64_unknown_redox,aarch64_unknown_teeos,aarch64_unknown_nuttx,aarch64_unknown_trusty,aarch64_wrs_vxworks,arm_linux_androideabi,arm_unknown_linux_gnueabi,arm_unknown_linux_gnueabihf,arm_unknown_linux_musleabi,arm_unknown_linux_musleabihf,armeb_unknown_linux_gnueabi,armebv7r_none_eabi,armebv7r_none_eabihf,armv4t_none_eabi,armv4t_unknown_linux_gnueabi,armv5te_none_eabi,armv5te_unknown_linux_gnueabi,armv5te_unknown_linux_musleabi,armv5te_unknown_linux_uclibceabi,armv6_unknown_freebsd,armv6_unknown_netbsd_eabihf,armv6k_nintendo_3ds,armv7_linux_androideabi,armv7_rtems_eabihf,armv7_sony_vita_newlibeabihf,armv7_unknown_freebsd,armv7_unknown_linux_gnueabi,armv7_unknown_linux_gnueabihf,armv7_unknown_linux_musleabi,armv7_unknown_linux_musleabihf,armv7_unknown_linux_ohos,armv7_unknown_linux_uclibceabi,armv7_unknown_linux_uclibceabihf,armv7_unknown_netbsd_eabihf,armv7_unknown_trusty,armv7_wrs_vxworks_eabihf,armv7a_kmc_solid_asp3_eabi,armv7a_kmc_solid_asp3_eabihf,armv7a_none_eabi,armv7a_none_eabihf,armv7a_nuttx_eabi,armv7a_nuttx_eabihf,armv7r_none_eabi,armv7r_none_eabihf,armv8r_none_eabihf,hexagon_unknown_linux_musl,hexagon_unknown_none_elf,i686_pc_nto_qnx700,i586_unknown_linux_gnu,i586_unknown_linux_musl,i586_unknown_netbsd,i586_unknown_redox,i686_linux_android,i686_unknown_freebsd,i686_unknown_haiku,i686_unknown_hurd_gnu,i686_unknown_linux_gnu,i686_unknown_linux_musl,i686_unknown_netbsd,i686_unknown_openbsd,i686_wrs_vxworks,loongarch64_unknown_linux_gnu,loongarch64_unknown_linux_musl,loongarch64_unknown_linux_ohos,loongarch64_unknown_none,loongarch64_unknown_none_softfloat,m68k_unknown_linux_gnu,m68k_unknown_none_elf,mips64_openwrt_linux_musl,mips64_unknown_linux_gnuabi64,mips64_unknown_linux_muslabi64,mips64el_unknown_linux_gnuabi64,mips64el_unknown_linux_muslabi64,mips_unknown_linux_gnu,mips_unknown_linux_musl,mips_unknown_linux_uclibc,mips_mti_none_elf,mipsel_mti_none_elf,mipsel_sony_psp,mipsel_sony_psx,mipsel_unknown_linux_gnu,mipsel_unknown_linux_musl,mipsel_unknown_linux_uclibc,mipsel_unknown_netbsd,mipsel_unknown_none,mipsisa32r6_unknown_linux_gnu,mipsisa32r6el_unknown_linux_gnu,mipsisa64r6_unknown_linux_gnuabi64,mipsisa64r6el_unknown_linux_gnuabi64,msp430_none_elf,powerpc64_unknown_freebsd,powerpc64_unknown_linux_gnu,powerpc64_unknown_linux_musl,powerpc64_unknown_openbsd,powerpc64_wrs_vxworks,powerpc64le_unknown_freebsd,powerpc64le_unknown_linux_gnu,powerpc64le_unknown_linux_musl,powerpc_unknown_freebsd,powerpc_unknown_linux_gnu,powerpc_unknown_linux_gnuspe,powerpc_unknown_linux_musl,powerpc_unknown_linux_muslspe,powerpc_unknown_netbsd,powerpc_unknown_openbsd,powerpc_wrs_vxworks,powerpc_wrs_vxworks_spe,riscv32_wrs_vxworks,riscv32e_unknown_none_elf,riscv32em_unknown_none_elf,riscv32emc_unknown_none_elf,riscv32gc_unknown_linux_gnu,riscv32gc_unknown_linux_musl,riscv32i_unknown_none_elf,riscv32im_risc0_zkvm_elf,riscv32im_unknown_none_elf,riscv32ima_unknown_none_elf,riscv32imac_esp_espidf,riscv32imac_unknown_none_elf,riscv32imac_unknown_xous_elf,riscv32imafc_unknown_none_elf,riscv32imafc_esp_espidf,riscv32imc_esp_espidf,riscv32imc_unknown_none_elf,riscv64_linux_android,riscv64_wrs_vxworks,riscv64gc_unknown_freebsd,riscv64gc_unknown_fuchsia,riscv64gc_unknown_hermit,riscv64gc_unknown_linux_gnu,riscv64gc_unknown_linux_musl,riscv64gc_unknown_netbsd,riscv64gc_unknown_none_elf,riscv64gc_unknown_openbsd,riscv64imac_unknown_none_elf,s390x_unknown_linux_gnu,s390x_unknown_linux_musl,sparc64_unknown_linux_gnu,sparc64_unknown_netbsd,sparc64_unknown_openbsd,sparc_unknown_linux_gnu,sparc_unknown_none_elf,sparcv9_sun_solaris,thumbv4t_none_eabi,thumbv5te_none_eabi,thumbv6m_none_eabi,thumbv7em_none_eabi,thumbv7em_none_eabihf,thumbv7m_none_eabi,thumbv7neon_linux_androideabi,thumbv7neon_unknown_linux_gnueabihf,thumbv7neon_unknown_linux_musleabihf,thumbv8m_base_none_eabi,thumbv8m_main_none_eabi,thumbv8m_main_none_eabihf,wasm32_unknown_emscripten,wasm32_unknown_unknown,wasm32v1_none,wasm32_wasip1,wasm32_wasip1_threads,wasm32_wasip2,wasm32_wali_linux_musl,wasm64_unknown_unknown,x86_64_fortanix_unknown_sgx,x86_64_linux_android,x86_64_lynx_lynxos178,x86_64_pc_nto_qnx710,x86_64_pc_nto_qnx710_iosock,x86_64_pc_nto_qnx800,x86_64_pc_solaris,x86_64_unikraft_linux_musl,x86_64_unknown_dragonfly,x86_64_unknown_freebsd,x86_64_unknown_fuchsia,x86_64_unknown_haiku,x86_64_unknown_hurd_gnu,x86_64_unknown_hermit,x86_64_unknown_illumos,x86_64_unknown_l4re_uclibc,x86_64_unknown_linux_gnu,x86_64_unknown_linux_gnux32,x86_64_unknown_linux_musl,x86_64_unknown_linux_ohos,x86_64_unknown_linux_none,x86_64_unknown_netbsd,x86_64_unknown_none,x86_64_unknown_openbsd,x86_64_unknown_redox,x86_64_unknown_trusty,x86_64_wrs_vxworks,thumbv6m_nuttx_eabi,thumbv7a_nuttx_eabi,thumbv7a_nuttx_eabihf,thumbv7m_nuttx_eabi,thumbv7em_nuttx_eabi,thumbv7em_nuttx_eabihf,thumbv8m_base_nuttx_eabi,thumbv8m_main_nuttx_eabi,thumbv8m_main_nuttx_eabihf,riscv32imc_unknown_nuttx_elf,riscv32imac_unknown_nuttx_elf,riscv32imafc_unknown_nuttx_elf,riscv64imac_unknown_nuttx_elf,riscv64gc_unknown_nuttx_elf)" "-O" "-Cdebug-assertions=no" "-C" "prefer-dynamic" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\assembly\\targets\\targets-elf.armeb_unknown_linux_gnueabi\\libminicore.rlib" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "--target" "armeb-unknown-linux-gnueabi" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcCKCdDh"

error: aborting due to 1 previous error
------------------------------------------


---
test result: FAILED. 495 passed; 1 failed; 43 ignored; 0 measured; 0 filtered out; finished in 28.05s

Some tests failed in compiletest suite=assembly mode=assembly host=x86_64-pc-windows-msvc target=x86_64-pc-windows-msvc
Build completed unsuccessfully in 1:36:49
make: *** [Makefile:113: ci-msvc-py] Error 1
  local time: Fri Apr 25 04:05:20 CUT 2025
  network time: Fri, 25 Apr 2025 04:05:20 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
Copy link
Collaborator

bors commented Apr 25, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 25, 2025
@Zalathar
Copy link
Contributor Author

@bors retry (msvc; couldn't create a temp dir)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2025
@Zalathar Zalathar added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. CI-spurious-fail-msvc CI spurious failure: target env msvc and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 25, 2025
@bors
Copy link
Collaborator

bors commented Apr 25, 2025

⌛ Testing commit d0a4580 with merge 862156d...

@jieyouxu jieyouxu added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2025
@bors
Copy link
Collaborator

bors commented Apr 25, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 862156d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 25, 2025
@bors bors merged commit 862156d into rust-lang:master Apr 25, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 25, 2025
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 847e3ee (parent) -> 862156d (this PR)

Test differences

Show 33060 test diffs

Stage 1

  • analyze_source_file::tests::multi_byte_char_across_chunk_boundary: pass -> [missing] (J0)
  • coverage::counters::node_flow::tests::example_driver: pass -> [missing] (J0)
  • errors::verify_ast_lowering_default_field_in_tuple_0: pass -> [missing] (J0)
  • errors::verify_codegen_ssa_mixed_export_name_and_no_mangle_138: pass -> [missing] (J0)
  • errors::verify_interface_proc_macro_crate_panic_abort_12: pass -> [missing] (J0)
  • errors::verify_parse_bad_item_kind_142: pass -> [missing] (J0)
  • errors::verify_parse_cr_doc_comment_97: pass -> [missing] (J0)
  • errors::verify_parse_expected_fn_path_found_fn_keyword_56: pass -> [missing] (J0)
  • errors::verify_parse_extern_item_cannot_be_const_76: pass -> [missing] (J0)
  • errors::verify_parse_incorrect_visibility_restriction_38: pass -> [missing] (J0)
  • errors::verify_parse_nonterminal_expected_statement_90: pass -> [missing] (J0)
  • errors::verify_parse_unexpected_token_after_struct_name_found_reserved_identifier_80: pass -> [missing] (J0)
  • errors::verify_passes_doc_alias_duplicated_26: pass -> [missing] (J0)
  • errors::verify_privacy_unnamed_item_is_private_1: pass -> [missing] (J0)
  • graph::scc::tests::test_max_branch: pass -> [missing] (J0)
  • lints::verify_lint_overflowing_literal_85: pass -> [missing] (J0)
  • btree::map::from_iter_seq_100: pass -> [missing] (J1)
  • linked_list::bench_collect_into: pass -> [missing] (J1)
  • num::flt2dec::bench_big_shortest: pass -> [missing] (J1)
  • sort::tests::unstable::stability_i32_random_d2: pass -> [missing] (J1)
  • str::trim_start_ascii_char::short_mixed: pass -> [missing] (J1)
  • ascii_char::test_debug_control: pass -> [missing] (J2)
  • cell::ref_map_does_not_update_flag: pass -> [missing] (J2)
  • collections::binary_heap::test_drain_sorted_forget: pass -> [missing] (J2)
  • collections::binary_heap::test_drain_sorted_leak: pass -> [missing] (J2)
  • collections::hash::map::tests::test_clone: pass -> [missing] (J2)
  • collections::hash::map::tests::test_create_capacity_zero: pass -> [missing] (J2)
  • collections::linked_list::tests::test_cursor_push_front_back: pass -> [missing] (J2)
  • fmt::builders::debug_list::test_multiple_non_exhaustive: pass -> [missing] (J2)
  • hash::sip::test_hash_no_bytes_dropped_64: pass -> [missing] (J2)
  • io::cursor::tests::test_boxed_slice_reader_vectored: pass -> [missing] (J2)
  • io::tests::chain_splitted_char: pass -> [missing] (J2)
  • io::tests::take_eof: pass -> [missing] (J2)
  • num::test_i16i32: pass -> [missing] (J2)
  • num::test_try_i128i128: pass -> [missing] (J2)
  • option::test_unwrap_unchecked: pass -> [missing] (J2)
  • rc::into_from_raw: pass -> [missing] (J2)
  • sort::tests::unstable::basic: pass -> [missing] (J2)
  • str::test_into_string: pass -> [missing] (J2)
  • str::trim_ws: pass -> [missing] (J2)
  • time::secs: pass -> [missing] (J2)
  • io::tests::bench_read_to_end: ignore -> [missing] (J3)
  • sort::tests::stable::correct_i32_random_d311: ignore -> [missing] (J3)
  • sort::tests::stable::stability_cell_i32_random_d2: ignore -> [missing] (J3)
  • sort::tests::unstable::violate_ord_retain_orig_set_cell_i32_descending: ignore -> [missing] (J3)

Stage 2

  • coverage::counters::union_find::tests::transitive: [missing] -> pass (J0)
  • errors::verify_codegen_ssa_rlib_missing_format_40: [missing] -> pass (J0)
  • errors::verify_interface_ignoring_extra_filename_14: [missing] -> pass (J0)
  • errors::verify_metadata_incompatible_rustc_68: [missing] -> pass (J0)
  • errors::verify_parse_incorrect_use_of_await_1: [missing] -> pass (J0)
  • errors::verify_passes_unlabeled_cf_in_while_condition_131: [missing] -> pass (J0)
  • errors::verify_resolve_imports_cannot_refer_to_26: [missing] -> pass (J0)
  • lints::verify_lint_builtin_mutable_transmutes_28: [missing] -> pass (J0)
  • lints::verify_lint_invalid_null_arguments_45: [missing] -> pass (J0)
  • maybe_transmutable::tests::safety::src_unsafe_dst_safe: [missing] -> pass (J0)
  • source_map::tests::span_merging_fail: [missing] -> pass (J0)
  • spec::tests::armv4t_none_eabi: [missing] -> pass (J0)
  • spec::tests::nvptx64_nvidia_cuda: [missing] -> pass (J0)
  • spec::tests::x86_64_unknown_hurd_gnu: [missing] -> pass (J0)
  • test_int_ranges: [missing] -> pass (J0)
  • array::map_8byte_8byte_64: [missing] -> pass (J1)
  • btree::map::from_iter_seq_10_000: [missing] -> pass (J1)
  • fs::tests::unlink_readonly: [missing] -> pass (J1)
  • hash::set_ops::set_intersection: [missing] -> pass (J1)
  • io::tests::bench_read_to_end: [missing] -> pass (J1)
  • iter::bench_inspect_chain_sum: [missing] -> pass (J1)
  • sort::tests::stable::deterministic_i32_descending: [missing] -> pass (J1)
  • sort::tests::stable::self_cmp_cell_i32_random_d2: [missing] -> pass (J1)
  • sort::tests::unstable::correct_1k_random_s95: [missing] -> pass (J1)
  • sort::tests::unstable::correct_f128_descending: [missing] -> pass (J1)
  • string::bench_insert_str_long: [missing] -> pass (J1)
  • vec::bench_clone_0100: [missing] -> pass (J1)
  • vec::bench_clone_from_01_0010_0010: [missing] -> pass (J1)
  • vec::bench_dedup_none_10000: [missing] -> pass (J1)
  • vec_deque::bench_extend_vec: [missing] -> pass (J1)
  • ascii::test_escape_ascii_iter: [missing] -> pass (J2)
  • borrow::test_from_cow_slice: [missing] -> pass (J2)
  • collections::btree::borrow::tests::test_borrow: [missing] -> pass (J2)
  • collections::btree::map::tests::test_try_insert: [missing] -> pass (J2)
  • io::error::tests::test_custom_error_packing: [missing] -> pass (J2)
  • iter::adapters::array_chunks::test_iterator_array_chunks_try_rfold: [missing] -> pass (J2)
  • mpsc_sync::oneshot_multi_thread_send_close_stress: [missing] -> pass (J2)
  • net::ip_addr::ipv6_to_ipv4_mapped: [missing] -> pass (J2)
  • nonzero::test_from_str: [missing] -> pass (J2)
  • num::dec2flt::parse::issue31109: [missing] -> pass (J2)
  • num::i16::test_rem_euclid: [missing] -> pass (J2)
  • num::ieee754::infinity_to_str: [missing] -> pass (J2)
  • num::u64::test_pow: [missing] -> pass (J2)
  • num::u64::test_unbounded_shr: [missing] -> pass (J2)
  • slice::repeat_generic_slice: [missing] -> pass (J2)
  • slice::slice_index::rangetoinclusive_len::pass: [missing] -> pass (J2)
  • slice::test_rchunks_exact_mut_zip: [missing] -> pass (J2)
  • str::slice_index::boundary::rangefrom::pass: [missing] -> pass (J2)
  • sys_common::tests::test_muldiv: [missing] -> pass (J2)
  • sys_common::wtf8::tests::wtf8_slice_not_code_point_boundary: [missing] -> pass (J2)
  • vec::test_drain_keep_rest_all: [missing] -> pass (J2)
  • vec_deque::test_resize_keeps_reserved_space_from_item: [missing] -> pass (J2)
  • vec_deque::test_rev_iter: [missing] -> pass (J2)
  • thread::tests::test_minimal_thread_stack: [missing] -> pass (J3)
  • f16::test_max_nan: [missing] -> pass (J4)

(and 16442 additional test diffs)

Additionally, 16518 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 862156d6f25ccb0d915d2a0c8ebab520d05e4f72 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 5185.7s -> 1227.6s (-76.3%)
  2. test-various: 4147.8s -> 2232.1s (-46.2%)
  3. x86_64-gnu-aux: 6338.0s -> 4182.6s (-34.0%)
  4. dist-aarch64-linux: 7914.2s -> 5590.1s (-29.4%)
  5. dist-x86_64-apple: 11170.0s -> 8541.0s (-23.5%)
  6. x86_64-apple-1: 7805.0s -> 5978.7s (-23.4%)
  7. dist-powerpc-linux: 5178.5s -> 5882.6s (13.6%)
  8. aarch64-apple: 3670.3s -> 3180.8s (-13.3%)
  9. dist-loongarch64-linux: 7264.5s -> 6344.5s (-12.7%)
  10. x86_64-gnu-distcheck: 4422.4s -> 4909.8s (11.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Zalathar Zalathar deleted the revert-new-executor branch April 25, 2025 09:32
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (862156d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.7% [-2.7%, -0.9%] 3
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.7% [-2.7%, -0.9%] 3

Cycles

Results (primary 0.7%, secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.9% [0.5%, 1.4%] 4
Regressions ❌
(secondary)
1.4% [1.3%, 1.5%] 3
Improvements ✅
(primary)
-0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)
-2.4% [-2.6%, -2.1%] 2
All ❌✅ (primary) 0.7% [-0.4%, 1.4%] 5

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.153s -> 777.547s (0.18%)
Artifact size: 365.17 MiB -> 365.15 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc CI-spurious-fail-msvc CI spurious failure: target env msvc CI-spurious-fail-rust-lld-crash CI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruption merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants