Skip to content

Tracking issue for new compiletest executor #140192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
jieyouxu opened this issue Apr 23, 2025 · 0 comments
Open
1 task done

Tracking issue for new compiletest executor #140192

jieyouxu opened this issue Apr 23, 2025 · 0 comments
Labels
A-compiletest Area: The compiletest test runner A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Apr 23, 2025

This is a tracking issue for migrating towards a new compiletest executor to replace the dependency on the
libtest executor.

This tracking issue is not meant for discussions or bug reports but is meant to track implementation progress, please open individual issues for bugs / discussions or zulip threads instead.

Summary

compiletest currently relies on the in-tree libtest (unstable programmatic API). This is problematic because:

  1. This can cause unnecessary compiler rebuilds following the stage 0 std redesign (this is mitigated by bootstrap build.compiletest-use-stage0-libtest = true but that's more-or-less a hack / mitigation).
    • This workaround can additional cause friction for contributors modifying programmatic libtest API due to stage 0 vs in-tree libtest differences.
  2. This is quite restrictive for compiletest because we can't easily tailor libtest behavior for rustc/rustdoc/ certain library test suites without regressing all the other libtest consumers.

Instead, we can roll our own minimal executor that replaces the libtest executor, which would allow us to drop the dependency on libtest once we migrate over to the new executor.

Known limitations

  • The current new executor implementation still depends on an unstable library feature, namely #![feature(internal_output_capture)].

Known bugs

Implementation history

@jieyouxu jieyouxu added A-compiletest Area: The compiletest test runner A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 23, 2025
@jieyouxu jieyouxu moved this from Backlog to In progress in compiletest maintenance and improvements Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiletest Area: The compiletest test runner A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
Status: In progress
Development

No branches or pull requests

1 participant