Fix siginfo_t
for Illumos
#2696
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
siginfo_t
struct appears to be incorrect for Illumos. It currently hassi_code
beforesi_errno
and appears to be too large. I'm not familiar with this platform, so please let me know if this fix is inaccurate.siginfo_t
:https://github.com/illumos/illumos-gate/blob/74e98f497ae878ae481ccba1f91fd8dc26fa6627/usr/src/boot/sys/sys/signal.h#L196
siginfo.h:
https://github.com/illumos/illumos-gate/blob/74e98f497ae878ae481ccba1f91fd8dc26fa6627/usr/src/uts/common/sys/siginfo.h#L164
I am not sure if the
packed()
attribute should remain, but I copied it from the Solaris definition.