Skip to content

solarish: Expose siginfo_t data as functions #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2022
Merged

solarish: Expose siginfo_t data as functions #2697

merged 1 commit into from
Feb 23, 2022

Conversation

pfmooney
Copy link
Contributor

This will bring illumos (and Solaris) functionality in line with the other UNIX (and UNIX-like) platforms, where unions often hamper access to those data fields.

@rust-highfive
Copy link

Some changes occurred in solarish module

cc @jclulow,@pfmooney

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@pfmooney
Copy link
Contributor Author

Hopefully this will address the needs that @dylni brought up in #2696.

@pfmooney pfmooney mentioned this pull request Feb 22, 2022
Closed
@pfmooney
Copy link
Contributor Author

The normal libc-test suite runs clean (both with and without the extra_traits feature). I also sketched up a little test program which imported siginfo_t instances allocated and populated from C to check the rust-libc parsing. Those results were OK as well.

@Amanieu
Copy link
Member

Amanieu commented Feb 23, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Feb 23, 2022

📌 Commit aa8f0f2 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Feb 23, 2022

⌛ Testing commit aa8f0f2 with merge 894646a...

bors added a commit that referenced this pull request Feb 23, 2022
@bors
Auto merge of #2697 - pfmooney:illumos-siginfo, r=Amanieu
894646a 
solarish: Expose siginfo_t data as functions

This will bring illumos (and Solaris) functionality in line with the other UNIX (and UNIX-like) platforms, where unions often hamper access to those data fields.
@bors
Copy link
Contributor

bors commented Feb 23, 2022

💔 Test failed - checks-actions

@pfmooney
solarish: Expose siginfo_t data as functions
52d5741 
This will bring illumos (and Solaris) functionality in line with the
other UNIX (and UNIX-like) platforms, where unions often hamper access
to those data fields.
@pfmooney
Copy link
Contributor Author

broken_heart Test failed - checks-actions

I removed the compilation-conditional around si_pad for now to appease the compiler.

@Amanieu
Copy link
Member

Amanieu commented Feb 23, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Feb 23, 2022

📌 Commit 52d5741 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Feb 23, 2022

⌛ Testing commit 52d5741 with merge 13d18ee...

@bors
Copy link
Contributor

bors commented Feb 23, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 13d18ee to master...

@bors bors merged commit 13d18ee into rust-lang:master Feb 23, 2022
@pfmooney
Copy link
Contributor Author

Thanks for the prompt review.

@pfmooney pfmooney deleted the illumos-siginfo branch August 9, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pfmooney @rust-highfive @Amanieu @bors