Keep arguments in redirections

[GuillaumeGomez]

Fixes #2786.

I created a new type to ensure that the escaping was done only once.

[syphar]

we probably also should update the rustdoc_redirector_handler to forward the query args.

Also we should see if the trailing-slash-redirect we're using also forwards the query (not sure if we should spend time on fixing it if it doesn't).

[GuillaumeGomez]

Only using the query now.

[syphar]

we probably also should update the rustdoc_redirector_handler to forward the query args.

did you intentionally leave out the redirector handler?

[GuillaumeGomez]

There was only one case which needed it as most of them are already using redirect_to_doc which adds redirections. Anyway, I think all of them are covered now.

[syphar]

Nearly there, thank you for working on this!

[syphar]

generally: with all the github noise I typically work with the personal "review requests" tab quite much, and check these more often than notifications in general, so re-requesting a review when it's ready again really helps me.

( I'll see the other notifications later too, but not as fast)

[GuillaumeGomez]

generally: with all the github noise I typically work with the personal "review requests" tab quite much, and check these more often than notifications in general, so re-requesting a review when it's ready again really helps me.

( I'll see the other notifications later too, but not as fast)

Noted!

[GuillaumeGomez]

Added your test. :)