Skip to content

docs.rs removes query parameters on redirect #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msrd0 opened this issue Apr 5, 2025 · 3 comments · May be fixed by #2800
Open

docs.rs removes query parameters on redirect #2786

msrd0 opened this issue Apr 5, 2025 · 3 comments · May be fixed by #2800
Labels
A-backend Area: Webserver backend C-bug Category: This is a bug

Comments

@msrd0
Copy link

msrd0 commented Apr 5, 2025

When requesting a url on docs.rs that gets redirected e.g. because the wrong version of -/_ was used, e.g. https://docs.rs/embedded_graphics/0.8.0/embedded_graphics, and you add query parameters, e.g. https://docs.rs/embedded_graphics/0.8.0/embedded_graphics/?search=pixel, you get redirected to https://docs.rs/embedded-graphics/0.8.0/embedded_graphics/ with the query parameter stripped. I think the redirect should instead go to https://docs.rs/embedded-graphics/0.8.0/embedded_graphics/?search=pixel, i.e. keeping the query parameters.

@syphar
Copy link
Member

syphar commented Apr 7, 2025

You're right, I'm actually surprised this didn't occur to anyone before.

@syphar syphar added C-bug Category: This is a bug A-backend Area: Webserver backend labels Apr 7, 2025
@GuillaumeGomez
Copy link
Member

Taking a look.

@GuillaumeGomez GuillaumeGomez linked a pull request Apr 11, 2025 that will close this issue
@GuillaumeGomez
Copy link
Member

Fixed in #2800.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend Area: Webserver backend C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants