Add feature gate for atomic load/store, gate spsc
behind loadstore
(Alternative fix for #271)
#273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
spsc
module should only be build whenatomic_polyfill
is available. It's a big dependency (pulls in 12 extra dependencies) so for projects that don't need the atomics it's better to hide it behind a (default) feature gate.I added two new features:
loadstore
that pulls inatomic_polyfill
for architectures that need it and gatesspsc
atomics
that enablesloadstone
andcas
(replacescas
as the default feature)Doing it this way should allow for more granular configuration of architectures, i.e. only pull-in
atomic_polyfill
if an architecture usesloadstore
and doesn't have native support. This pull request does not contain that granularity as I'm not familiar with other architectures.