Skip to content

Commit 4a207ae

Browse files
bors[bot]japaric
andauthored
Merge #293
293: unconditionally depend on atomic-polyfill for riscv32i target r=japaric a=japaric due to a limitation in the llvm backend [1] the `riscv32i-unknown-none-elf` target lacks the `core::sync::atomic` API even though the actual hardware is capable of atomic loads and stores (`fence` instruction). thus, at this point in time, this target needs `atomic-polyfill` for a working SPSC implementation [1]: knurling-rs/defmt#597 (comment) fixes #271 closes #272 closes #273 Co-authored-by: Jorge Aparicio <[email protected]>
2 parents c2a022d + 34b05be commit 4a207ae

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ jobs:
5353
- nightly
5454
features:
5555
- ""
56+
- "cas"
5657
- "serde"
5758
steps:
5859
- name: Checkout
@@ -92,7 +93,7 @@ jobs:
9293
with:
9394
use-cross: false
9495
command: check
95-
args: --target=${{ matrix.target }} --features=${{ matrix.features }}
96+
args: --target=${{ matrix.target }} --no-default-features --features=${{ matrix.features }}
9697

9798
# Run cpass tests
9899
testcpass:

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1919
### Changed
2020

2121
* Optimize the codegen of `Vec::clone`
22+
* `riscv32i` targets unconditionally (`no-default-features`) depends on `atomic-polyfill`
2223

2324
### Fixed
2425

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ defmt-impl = ["defmt"]
3131
atomic-polyfill = { version = "0.1.2", optional = true }
3232

3333
[target.riscv32i-unknown-none-elf.dependencies]
34-
atomic-polyfill = { version = "0.1.4", optional = true }
34+
atomic-polyfill = { version = "0.1.4" }
3535

3636
[target.riscv32imc-unknown-none-elf.dependencies]
3737
atomic-polyfill = { version = "0.1.4", optional = true }

0 commit comments

Comments
 (0)