Skip to content

feat: make async Write::flush a required method #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: make async Write::flush a required method #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions embedded-io-async/src/impls/slice_mut.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,9 @@ impl Write for &mut [u8] {
*self = b;
Ok(amt)
}

#[inline]
async fn flush(&mut self) -> Result<(), Self::Error> {
Ok(())
}
}
5 changes: 5 additions & 0 deletions embedded-io-async/src/impls/vec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,9 @@ impl Write for Vec<u8> {
self.extend_from_slice(buf);
Ok(buf.len())
}

#[inline]
async fn flush(&mut self) -> Result<(), Self::Error> {
Ok(())
}
}
4 changes: 1 addition & 3 deletions embedded-io-async/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,7 @@ pub trait Write: ErrorType {
async fn write(&mut self, buf: &[u8]) -> Result<usize, Self::Error>;

/// Flush this output stream, ensuring that all intermediately buffered contents reach their destination.
async fn flush(&mut self) -> Result<(), Self::Error> {
Ok(())
}
async fn flush(&mut self) -> Result<(), Self::Error>;

/// Write an entire buffer into this writer.
///
Expand Down