feat: make async Write::flush a required method
#696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
force-pushed
the
async-write-flush
branch
from
4dfa785 to
ad2fb51
Compare
mkroening
force-pushed
the
async-write-flush
branch
from
ad2fb51 to
aa3f838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
embedded-io-async'sWrite::flushmethod a required method, meaning all implementors have to implement it.This aligns this method with
std'sWrite::flushandembedded-io'sWrite::flush.This PR is more a question than a proposal.
I could not find any documented reasons for the async
flushbeing a provided method.If this turns out to be intentional, I am happy to leave it as is and document the reason instead.
CC: @Dirbaio, who added this in the initial design (
d6f6419).