correctly take unstable-features #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ryankurte (rust-highfive has picked a reviewer for you, use r? to override) |
|
ci errors are one of the issues with not having a lockfile :), we could specify --locked to avoid this. can bump MSRV |
I think that's probably the way to go... |
Emilgardis
force-pushed
the
fix/issue127
branch
2 times, most recently
from
da08b60 to
9810486
Compare
|
done, we should get a release out after this too |
therealprof
previously approved these changes
Aug 15, 2022
bors bot
added a commit
that referenced
this pull request
Aug 15, 2022
128: correctly take unstable-features r=therealprof a=Emilgardis fixes #127 Co-authored-by: Emil Gardström <[email protected]>
|
Timed out. |
|
interesting. bors retry |
bors bot
added a commit
that referenced
this pull request
Aug 15, 2022
128: correctly take unstable-features r=therealprof a=Emilgardis fixes #127 Co-authored-by: Emil Gardström <[email protected]>
|
bors cancel the bors matrix is looking for version number |
|
Canceled. |
|
bors try should fail |
tryBuild failed: |
Emilgardis
commented
Aug 15, 2022
.github/workflows/ci.yml
Outdated
Comment on lines
75
to
82
| if: always() | ||
| steps: | ||
| - name: Result | ||
| run: | | ||
| jq -C <<< "${needs}" | ||
| "$(jq -r 'all(.result as $result | (["success"] | contains([$result])))' <<< "${needs}")" | ||
| env: | ||
| needs: ${{ toJson(needs) }} |
There was a problem hiding this comment.
technically, this is not needed. Could simply be
Suggested change
| if: always() | |
| steps: | |
| - name: Result | |
| run: | | |
| jq -C <<< "${needs}" | |
| "$(jq -r 'all(.result as $result | (["success"] | contains([$result])))' <<< "${needs}")" | |
| env: | |
| needs: ${{ toJson(needs) }} | |
| steps: | |
| - name: Result | |
| run: exit 0 |
Emilgardis
force-pushed
the
fix/issue127
branch
from
2ecefc9 to
d5e977d
Compare
Emilgardis
force-pushed
the
fix/issue127
branch
from
d5e977d to
538a26d
Compare
Emilgardis
force-pushed
the
fix/issue127
branch
from
538a26d to
87d47a6
Compare
|
bumping msrv due to rust-lang/rust#105167 on macos |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #127