Skip to content

Consider moving away from rustc-cfg? #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brightly-salty opened this issue Jan 17, 2021 · 3 comments
Closed

Consider moving away from rustc-cfg? #100

brightly-salty opened this issue Jan 17, 2021 · 3 comments

Comments

@brightly-salty
Copy link

It looks like rustc-cfg is unmaintained or at least dormant. There are no commits since October 2018, and it's dependence on failure (despite a PR to fix it) makes cargo-audit fail for cargo-binutils and anything that depends on it.

It might be better to move this functionality into cargo-binutils itself. rustc-cfg/src/lib.rs contains less than 200 lines of code, many of which are comments. If the licenses are compatible, I think it would be beneficial to move this file/code into cargo-binutils so it can continue to receive maintenance and updates.

@therealprof
Copy link
Contributor

Fair enough. @japaric who's both the original author of the dependency in question and cargo-binutils might have an opinion on how we could proceed here.

@japaric
Copy link
Member

japaric commented Feb 15, 2021

Importing rustc-cfg code into this repo seems fine to me. I think there's another crate that does about the same as rustc-cfg but I can't remember the name right now.

@Emilgardis
Copy link
Member

rustc-cfg was updated in #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants