Fix Markdown strikethrough (~~text~~) not rendering in HTML output
#1541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🚀 Preview deployment available at: https://5399d6da.rdoc-6cd.pages.dev (commit: 92b6e13) |
The Markdown parser correctly parsed `~~text~~` syntax but the AttributeManager did not recognize the resulting formats for HTML conversion: - Single words: `~~word~~` -> `~word~` (not registered as word pair) - Multi-word: `~~words here~~` -> `<s>words here</s>` (tag not registered) Add support for strikethrough formatting: - Register `~` as word pair for `:STRIKE` attribute - Register `<s>`, `<del>` HTML tags for `:STRIKE` - Add `:STRIKE` -> `<del>` tag mapping in `ToHtml` All strikethrough input formats now render as `<del>text</del>` in HTML.
st0012
force-pushed
the
fix-markdown-strike-issue
branch
from
53c1b88 to
92b6e13
Compare
st0012
added a commit
that referenced
this pull request
Jan 4, 2026
1. README now has a better section about supported markup formats 2. RDoc markup related reference are now consolidated under `doc/markup_reference/rdoc.rdoc` 3. Markdown markup now has a more comprehensive reference in `doc/markup_reference/markdown.md` (#1536, #1538, #1540, and #1541 were all discovered when I was preparing for this PR 😄)
st0012
added a commit
that referenced
this pull request
Jan 5, 2026
1. GitHub doesn't support `~word~` syntax for strikethrough, so we shouldn't either. 2. It's hard to make RDoc markup support `~~word~~` without supporting `~word~` as well due to the way attribute manager works. So instead we rollback the support added in #1541. Users can still use `<del>text</del>` syntax for strikethrough. 3. Fix `<code><del>text</del></code>` not rendering as `<del>text</del>` in HTML output. 4. Update documentation to reflect the new support.
st0012
added a commit
that referenced
this pull request
Jan 5, 2026
1. GitHub doesn't support `~word~` syntax for strikethrough, so we shouldn't either. 2. It's hard to make RDoc markup support `~~word~~` without supporting `~word~` as well due to the way attribute manager works. So instead we rollback the support added in #1541. Users can still use `<del>text</del>` syntax for strikethrough. 3. Fix `<code><del>text</del></code>` not rendering as `<del>text</del>` in HTML output. 4. Update documentation to reflect the new support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Markdown parser correctly parsed
~~text~~syntax but theAttributeManagerdid not recognize the resulting formats for HTML conversion:~~word~~->~word~(not registered as word pair)~~words here~~-><s>words here</s>(tag not registered)Add support for strikethrough formatting:
~as word pair for:STRIKEattribute<s>,<del>, and<strike>HTML tags for:STRIKE:STRIKE-><del>tag mapping inToHtmlAll strikethrough input formats now render as
<del>text</del>in HTML.