Align strikethrough support with GitHub Markdown #1548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. GitHub doesn't support `~word~` syntax for strikethrough, so we shouldn't either. 2. It's hard to make RDoc markup support `~~word~~` without supporting `~word~` as well due to the way attribute manager works. So instead we rollback the support added in #1541. Users can still use `<del>text</del>` syntax for strikethrough. 3. Fix `<code><del>text</del></code>` not rendering as `<del>text</del>` in HTML output. 4. Update documentation to reflect the new support.
Collaborator
|
🚀 Preview deployment available at: https://1f4a0528.rdoc-6cd.pages.dev (commit: 1aae619) |
tompng
approved these changes
Jan 5, 2026
skatkov
reviewed
Jan 5, 2026
|
|
||
| Rendered HTML: | ||
|
|
||
| >>> |
There was a problem hiding this comment.
question: Is this is a leftover from merge conflict?
Contributor
What? I very rarely use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~word~syntax for strikethrough, so we shouldn't either.~~word~~without supporting~word~as well due to the way attribute manager works. So instead we rollback the support added in Fix Markdown strikethrough (~~text~~) not rendering in HTML output #1541. Users can still use<del>text</del>syntax for strikethrough.<code><del>text</del></code>not rendering as<del>text</del>in HTML output.