Let's merge 0-8-stable to master

.gitignore

@@ -31,3 +31,6 @@ node_modules
 
 spec/test_app
 Gemfile.lock
+
+/gemfiles/*.lock
+/tmp

.rubocop.yml

@@ -1154,3 +1154,6 @@ Style/WordArray:
   Description: 'Use %w or %W for arrays of words.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#percent-w'
   Enabled: false
+
+Style/CommandLiteral:
+  EnforcedStyle: mixed

.travis.yml

@@ -4,6 +4,26 @@ rvm:
   - 2.0.0
   - 2.1
   - jruby-19mode
+before_script:
+  - phantomjs --version
 script:
   - bundle exec rake test_app
   - bundle exec rake
+gemfile:
+  - gemfiles/opal_0.8_react_13.gemfile
+  - gemfiles/opal_0.8_react_14.gemfile
+  - gemfiles/opal_0.8_react_15.gemfile
+  - gemfiles/opal_0.9_react_13.gemfile
+  - gemfiles/opal_0.9_react_14.gemfile
+  - gemfiles/opal_0.9_react_15.gemfile
+
+# These two setup seems to run indefinitely long
+# further investigation required.
+matrix:
+  exclude:
+  - rvm: jruby-19mode
+    gemfile: gemfiles/opal_0.9_react_13.gemfile
+  - rvm: jruby-19mode
+    gemfile: gemfiles/opal_0.9_react_14.gemfile
+  - rvm: jruby-19mode
+    gemfile: gemfiles/opal_0.9_react_15.gemfile

Appraisals

@@ -0,0 +1,20 @@
+opal_versions = ['0.8', '0.9']
+react_versions_map = {
+  '13' => '~> 1.3.3',
+  '14' => '~> 1.6.2',
+  '15' => '~> 1.8.2'
+}
+opal_rails_versions_map = {
+  '0.8' => '~> 0.8.1',
+  '0.9' => '~> 0.9.0',
+}
+
+opal_versions.each do |opal_v|
+  react_versions_map.each do |react_v, react_rails_v|
+    appraise "opal-#{opal_v}-react-#{react_v}" do
+      gem 'opal', "~> #{opal_v}.0"
+      gem 'opal-rails', opal_rails_versions_map[opal_v]
+      gem 'react-rails', react_rails_v, require: false
+    end
+  end
+end

CHANGELOG.md

@@ -18,6 +18,17 @@ Whitespace conventions:
 - 1 spaces before normal text
  -->
 
+## [0.8.9] - Unreleased
+
+### Fixed
+
+- Gets rid of react warnings about updating state during render (#155)
+- Multiple HAML classes (i.e. div.foo.bar) was not working (regression introduced in 0.8.8)
+- Don't send nil (null) to form components as the value string (#157)
+- Process `params` (props) correctly when using `Element#on` or `Element#render` (#158)
+- Deprecate shallow param compare (#156)
+
+
 ## [0.8.8] - 2016-07-13
 
 ### Added

Gemfile

@@ -1,2 +1,6 @@
 source 'https://rubygems.org'
 gemspec
+
+group :development do
+  gem "appraisal"
+end

Rakefile

@@ -2,14 +2,25 @@ require 'bundler'
 Bundler.require
 Bundler::GemHelper.install_tasks
 
+# Store the BUNDLE_GEMFILE env, since rake or rspec seems to clean it
+# while invoking task.
+ENV['REAL_BUNDLE_GEMFILE'] = ENV['BUNDLE_GEMFILE']
 
 require 'rspec/core/rake_task'
 require 'opal/rspec/rake_task'
 
+begin
+  require "react-rails"
+rescue NameError
+end
+
 RSpec::Core::RakeTask.new('ruby:rspec')
-Opal::RSpec::RakeTask.new('opal:rspec') do |s|
+
+Opal::RSpec::RakeTask.new('opal:rspec') do |s, task|
+  s.append_path React::Rails::AssetVariant.new(addons: true).react_directory
   s.append_path 'spec/vendor'
   s.index_path = 'spec/index.html.erb'
+  task.timeout = 80000 if task
 end
 
 task :test do

component-name-lookup.md

@@ -0,0 +1,145 @@
+#### Notes on how component names are looked up
+
+Given:
+
+```ruby
+
+class Blat < React::Component::Base
+
+  render do
+    Bar()      
+    Foo::Bar()
+  end
+
+end
+
+class Bar < React::Component::Base
+end
+
+module Foo
+
+  class Bar < React::Component::Base
+
+    render do
+      Blat()
+      Baz()
+    end
+  end
+
+  class Baz < React::Component::Base
+  end
+
+end
+```
+
+The problem is that method lookup is different than constant lookup.  We can prove it by running this code:
+
+```ruby
+def try_it(test, &block)
+  puts "trying #{test}"
+  result = yield
+  puts "success#{': '+result.to_s if result}"
+rescue Exception => e
+  puts "failed: #{e}"
+ensure
+  puts "---------------------------------"
+end
+
+module Boom
+
+  Bar = 12
+
+  def self.Bar
+    puts "   Boom::Bar says hi"
+  end
+
+  class Baz
+    def doit
+      try_it("Bar()") { Bar() }
+      try_it("Boom::Bar()") {Boom::Bar()}
+      try_it("Bar") { Bar }
+      try_it("Boom::Bar") { Boom::Bar }
+    end
+  end
+end
+
+
+
+Boom::Baz.new.doit
+```
+
+which prints:
+
+```text
+trying Bar()
+failed: Bar: undefined method `Bar' for #<Boom::Baz:0x774>
+---------------------------------
+trying Boom::Bar()
+   Boom::Bar says hi
+success
+---------------------------------
+trying Bar
+success: 12
+---------------------------------
+trying Boom::Bar
+success: 12
+---------------------------------
+```
+
+[try-it](http://opalrb.org/try/?code:def%20try_it(test%2C%20%26block)%0A%20%20puts%20%22trying%20%23%7Btest%7D%22%0A%20%20result%20%3D%20yield%0A%20%20puts%20%22success%23%7B%27%3A%20%27%2Bresult.to_s%20if%20result%7D%22%0Arescue%20Exception%20%3D%3E%20e%0A%20%20puts%20%22failed%3A%20%23%7Be%7D%22%0Aensure%0A%20%20puts%20%22---------------------------------%22%0Aend%0A%0Amodule%20Boom%0A%20%20%0A%20%20Bar%20%3D%2012%0A%20%20%0A%20%20def%20self.Bar%0A%20%20%20%20puts%20%22%20%20%20Boom%3A%3ABar%20says%20hi%22%0A%20%20end%0A%0A%20%20class%20Baz%0A%20%20%20%20def%20doit%0A%20%20%20%20%20%20try_it(%22Bar()%22)%20%7B%20Bar()%20%7D%0A%20%20%20%20%20%20try_it(%22Boom%3A%3ABar()%22)%20%7BBoom%3A%3ABar()%7D%0A%20%20%20%20%20%20try_it(%22Bar%22)%20%7B%20Bar%20%7D%0A%20%20%20%20%20%20try_it(%22Boom%3A%3ABar%22)%20%7B%20Boom%3A%3ABar%20%7D%0A%20%20%20%20end%0A%20%20end%0Aend%0A%20%20%0A%0A%0ABoom%3A%3ABaz.new.doit)
+
+
+What we need to do is:
+
+1. when defining a component class `Foo`, also define in the same scope that Foo is being defined a method `self.Foo` that will accept Foo's params and child block, and render it.
+
+2. As long as a name is qualified with at least one scope (i.e. `ModName::Foo()`) everything will work out, but if we say just `Foo()` then the only way I believe out of this is to handle it via method_missing, and let method_missing do a const_get on the method_name (which will return the class) and then render that component.
+
+#### details
+
+To define `self.Foo` in the same scope level as the class `Foo`, we need code like this:
+
+```ruby
+def register_component_dsl_method(component)
+  split_name = component.name && component.name.split('::')
+  return unless split_name && split_name.length > 2
+  component_name = split_name.last
+  parent = split_name.inject([Module]) { |nesting, next_const| nesting + [nesting.last.const_get(next_const)] }[-2]
+  class << parent
+    define_method component_name do |*args, &block|
+      React::RenderingContext.render(name, *args, &block)
+    end
+    define_method "#{component_name}_as_node" do |*args, &block|
+      React::Component.deprecation_warning("..._as_node is deprecated.  Render component and then use the .node method instead")
+      send(component_name, *args, &block).node
+    end
+  end
+end
+
+module React
+  module Component
+    def self.included(base)
+      ...
+      register_component_dsl_method(base.name)
+    end
+  end
+end
+```
+
+The component's method_missing function will look like this:
+
+```ruby
+def method_missing(name, *args, &block)
+  if name =~ /_as_node$/
+    React::Component.deprecation_warning("..._as_node is deprecated.  Render component and then use the .node method instead")
+    method_missing(name.gsub(/_as_node$/,""), *args, &block).node
+  else
+    component = const_get name if defined? name
+    React::RenderingContext.render(nil, component, *args, &block)
+  end
+end
+```
+
+### other related issues
+
+The Kernel#p method conflicts with the <p> tag.   However the p method can be invoked on any object so we are going to go ahead and use it, and deprecate the para method.

config.ru

@@ -1,15 +1,32 @@
 require 'bundler'
 Bundler.require
 
-require "opal-rspec"
-require "react/source"
+require "opal/rspec"
+require "opal-jquery"
 
-Opal.append_path File.expand_path('../spec', __FILE__)
+begin
+  require "react-rails"
+rescue NameError
+end
 
-run Opal::Server.new { |s|
-  s.main = 'opal/rspec/sprockets_runner'
-  s.append_path 'spec'
-  s.append_path File.dirname(::React::Source.bundled_path_for("react-with-addons.js"))
-  s.debug = true
-  s.index_path = 'spec/reactjs/index.html.erb'
-}
+if Opal::RSpec.const_defined?("SprocketsEnvironment")
+  sprockets_env = Opal::RSpec::SprocketsEnvironment.new
+  sprockets_env.cache = Sprockets::Cache::FileStore.new("tmp")
+  sprockets_env.add_spec_paths_to_sprockets
+  run Opal::Server.new(sprockets: sprockets_env) { |s|
+    s.main = 'opal/rspec/sprockets_runner'
+    s.append_path React::Rails::AssetVariant.new(addons: true).react_directory
+    s.debug = false
+    s.append_path 'spec/vendor'
+    s.index_path = 'spec/index.html.erb'
+  }
+else
+  run Opal::Server.new { |s|
+    s.main = 'opal/rspec/sprockets_runner'
+    s.append_path React::Rails::AssetVariant.new(addons: true).react_directory
+    s.append_path 'spec'
+    s.append_path 'spec/vendor'
+    s.debug = false
+    s.index_path = 'spec/index.html.erb'
+  }
+end

gemfiles/opal_0.8_react_13.gemfile

@@ -0,0 +1,13 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "opal", "~> 0.8.0"
+gem "opal-rails", "~> 0.8.1"
+gem "react-rails", "~> 1.3.3", :require => false
+
+group :development do
+  gem "appraisal"
+end
+
+gemspec :path => "../"

gemfiles/opal_0.8_react_14.gemfile

@@ -0,0 +1,13 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "opal", "~> 0.8.0"
+gem "opal-rails", "~> 0.8.1"
+gem "react-rails", "~> 1.6.2", :require => false
+
+group :development do
+  gem "appraisal"
+end
+
+gemspec :path => "../"

gemfiles/opal_0.8_react_15.gemfile

@@ -0,0 +1,13 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "opal", "~> 0.8.0"
+gem "opal-rails", "~> 0.8.1"
+gem "react-rails", "~> 1.8.2", :require => false
+
+group :development do
+  gem "appraisal"
+end
+
+gemspec :path => "../"

gemfiles/opal_0.9_react_13.gemfile

@@ -0,0 +1,13 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "opal", "~> 0.9.0"
+gem "opal-rails", "~> 0.9.0"
+gem "react-rails", "~> 1.3.3", :require => false
+
+group :development do
+  gem "appraisal"
+end
+
+gemspec :path => "../"

gemfiles/opal_0.9_react_14.gemfile

@@ -0,0 +1,13 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "opal", "~> 0.9.0"
+gem "opal-rails", "~> 0.9.0"
+gem "react-rails", "~> 1.6.2", :require => false
+
+group :development do
+  gem "appraisal"
+end
+
+gemspec :path => "../"

gemfiles/opal_0.9_react_15.gemfile

@@ -0,0 +1,13 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "opal", "~> 0.9.0"
+gem "opal-rails", "~> 0.9.0"
+gem "react-rails", "~> 1.8.2", :require => false
+
+group :development do
+  gem "appraisal"
+end
+
+gemspec :path => "../"

lib/generators/reactive_ruby/test_app/templates/assets/javascripts/components.rb

@@ -1,3 +1,4 @@
 require 'opal'
+require 'react'
 require 'reactive-ruby'
 require_tree './components'