This repository was archived by the owner on Oct 19, 2018. It is now read-only.
Let's merge 0-8-stable to master #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. React::Children is considered to be a Enumberable, so only #count method should be defined. 2. React::Children#each will returns a Enumerator, with #size returned nil when cannot count lazily, and in our case, it could be counted lazily.
commit 25c5f1e Author: Mitch VanDuyn <[email protected]> Date: Sat May 28 02:06:34 2016 -0400 tests passing using rake, react.js sources available, nice error displayed if react.js not available commit 2b544fc Author: Mitch VanDuyn <[email protected]> Date: Sat May 28 00:10:56 2016 -0400 all tests passing for react v13-v15 commit bda67e8 Author: Mitch VanDuyn <[email protected]> Date: Thu May 26 07:44:17 2016 -0400 wip commit 30e14c7 Author: Mitch VanDuyn <[email protected]> Date: Wed May 25 21:04:20 2016 -0400 removed require js commit 52e52b5 Author: Mitch VanDuyn <[email protected]> Date: Thu May 19 12:49:04 2016 -0400 bump to next version commit de5d685 Author: Mitch VanDuyn <[email protected]> Date: Thu May 19 12:47:11 2016 -0400 closes #142 closes #143
…ls” gem 1. Use `bundle exec appraisal install` to lock separate gem files 2. Use `bundle exec appraisal react-13 rake` to run separate gemfile , or `bundle exec appraisal rake` to run all variants.
This test case passed on opal 0.8 & react v13-15
catmando
approved these changes
Sep 21, 2016
`set_props` is no longer working in v15, we simply render again instead.
Shim `console.warn` trigger by “Object.freezing non support” added in opal 0.9
Reason still requires investigration.
Looks like rake or rspec will clean the previous BUNDLE_GEMFILE env. Workaround is to store the original one and set directly while shelling out.
In Opal 0.9, attr_reader returns nil if the backing instance variable is “undefined” which makes `React.Children.count` return 1 and break all the Enumerable#each method.
DOM element is not ready while test executed
define_method define a duplicated “para” method which got the wrong one pickuped by opal 0.9
This only exist in opal-rspec 0.5.0
# Conflicts: # lib/react/top_level.rb # spec/react/dsl_spec.rb
Original commit 5f9a829
ele raise const missing error, something is wrong with the `param` to automatically declare method, but given that we are going to deprecate this behavior, let’s make the test simpler and decoupled from that.
There is no need to update props_wrapper in lifecycle any more ,according to 0700a46
# Conflicts: # lib/reactive-ruby/version.rb
# Conflicts: # lib/reactive-ruby/rails/controller_helper.rb
# Conflicts: # lib/react/component/class_methods.rb
It takes indefinitely long and require further invesitigation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is a temporary branch to be applied with changes from 0-8-stable since the last time it got merged (which is de5d685).
After we got all the 0-8-stable added stuff to master, 0-8-stable branch will be feature freeze, and all the further dev will happen based on master.
React::Childrentest in opal 0.9/cc @catmando