Skip to content

Simplify CI & expand coverage #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 23, 2025
Merged

Simplify CI & expand coverage #1044

merged 12 commits into from
Mar 23, 2025

Conversation

datdenkikniet
Copy link
Contributor

@datdenkikniet datdenkikniet commented Mar 22, 2025

Instead of having a bunch of duplicate tasks, we can simply use/abuse the github matrices a little.

There's a bunch of repetition for platform/backend/toolchain combinations, but at least it's obvious what is and isn't being tested. We should be able to replace them with a YAML anchor once that's supported

Also add coverage for RISCV platforms/backends in clippy and check.

@datdenkikniet datdenkikniet marked this pull request as draft March 22, 2025 20:07
@datdenkikniet datdenkikniet force-pushed the simplify-ci branch 8 times, most recently from 10517c7 to ecb5ebc Compare March 22, 2025 20:36
@datdenkikniet datdenkikniet force-pushed the simplify-ci branch 3 times, most recently from 5c5fbf0 to 6b7a081 Compare March 22, 2025 20:56
@datdenkikniet datdenkikniet force-pushed the simplify-ci branch 2 times, most recently from b616242 to 49dda97 Compare March 22, 2025 21:27
@datdenkikniet datdenkikniet changed the title Simplify CI by using more matrix features Simplify CI & expand coverage Mar 22, 2025
@datdenkikniet datdenkikniet marked this pull request as ready for review March 22, 2025 21:53
@datdenkikniet datdenkikniet force-pushed the simplify-ci branch 16 times, most recently from f896cc1 to e5e497c Compare March 22, 2025 22:49
@datdenkikniet datdenkikniet added the skip-changelog Sometimes changes are not significant enough for a changelog entry label Mar 22, 2025
Copy link
Collaborator

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! The CI files were getting unwieldy. The only thing I think we should do in the future is to move as much as possible of all this into xtask or similar so one can do this locally and not need to have CI do it every time.

@datdenkikniet
Copy link
Contributor Author

datdenkikniet commented Mar 23, 2025

Yeah, this is initial clean up. I plan to move the book scripts into actual script files, and have asked @AfoHT to look over the QEMU setup (since I'm not sure the prebuilt binaries are really being used).

ETA: ah, and yes, moving this matrix into xtask would be good.

@datdenkikniet datdenkikniet added this pull request to the merge queue Mar 23, 2025
Merged via the queue into master with commit 11699b4 Mar 23, 2025
122 of 123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Sometimes changes are not significant enough for a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants