-
Notifications
You must be signed in to change notification settings - Fork 225
Simplify CI & expand coverage #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
10517c7
to
ecb5ebc
Compare
5c5fbf0
to
6b7a081
Compare
6b7a081
to
6870074
Compare
b616242
to
49dda97
Compare
6509a00
to
40f753c
Compare
40f753c
to
75ca569
Compare
4c733b1
to
ae2ad9f
Compare
f896cc1
to
e5e497c
Compare
e5e497c
to
b435905
Compare
78fb47f
to
6f77668
Compare
013086c
to
6f77668
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! The CI files were getting unwieldy. The only thing I think we should do in the future is to move as much as possible of all this into xtask
or similar so one can do this locally and not need to have CI do it every time.
Yeah, this is initial clean up. I plan to move the book scripts into actual script files, and have asked @AfoHT to look over the QEMU setup (since I'm not sure the prebuilt binaries are really being used). ETA: ah, and yes, moving this matrix into |
Instead of having a bunch of duplicate tasks, we can simply use/abuse the github matrices a little.
There's a bunch of repetition for platform/backend/toolchain combinations, but at least it's obvious what is and isn't being tested. We should be able to replace them with a YAML anchor once that's supported
Also add coverage for RISCV platforms/backends in clippy and check.