Skip to content

fix: update peerDependencies to support Rsbuild v2 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Jan 15, 2026
Merged

fix: update peerDependencies to support Rsbuild v2 #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"typescript": "^5.9.3"
},
"peerDependencies": {
"@rsbuild/core": "1.x"
"@rsbuild/core": "^1.0.0 || ^2.0.0-0"
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version range ^2.0.0-0 allows any v2 prerelease versions (alpha, beta, rc) which may contain breaking changes. Consider using ^2.0.0 instead to only allow stable v2 releases, or if prerelease support is needed, add explicit testing against v2 prerelease versions to ensure compatibility.

Suggested change
"@rsbuild/core": "^1.0.0 || ^2.0.0-0"
"@rsbuild/core": "^1.0.0 || ^2.0.0"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no test coverage for Rsbuild v2 compatibility. The existing tests in test/basic/index.test.ts and other test directories only verify functionality with v1. Consider adding tests that verify the plugin works correctly with both Rsbuild v1 and v2, or documenting which v2 APIs have been validated for compatibility.

Copilot uses AI. Check for mistakes.
},
"peerDependenciesMeta": {
"@rsbuild/core": {
Expand Down