fix: update peerDependencies to support Rsbuild v2#47
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the peer dependency specification for @rsbuild/core to support Rsbuild version 2.x in addition to the existing version 1.x support.
Changes:
- Modified
peerDependenciesto accept both Rsbuild v1 (^1.0.0) and v2 prerelease versions (^2.0.0-0)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "peerDependencies": { | ||
| "@rsbuild/core": "1.x" | ||
| "@rsbuild/core": "^1.0.0 || ^2.0.0-0" |
There was a problem hiding this comment.
The version range ^2.0.0-0 allows any v2 prerelease versions (alpha, beta, rc) which may contain breaking changes. Consider using ^2.0.0 instead to only allow stable v2 releases, or if prerelease support is needed, add explicit testing against v2 prerelease versions to ensure compatibility.
| "@rsbuild/core": "^1.0.0 || ^2.0.0-0" | |
| "@rsbuild/core": "^1.0.0 || ^2.0.0" |
| }, | ||
| "peerDependencies": { | ||
| "@rsbuild/core": "1.x" | ||
| "@rsbuild/core": "^1.0.0 || ^2.0.0-0" |
There was a problem hiding this comment.
There is no test coverage for Rsbuild v2 compatibility. The existing tests in test/basic/index.test.ts and other test directories only verify functionality with v1. Consider adding tests that verify the plugin works correctly with both Rsbuild v1 and v2, or documenting which v2 APIs have been validated for compatibility.
1 participant
No description provided.