Skip to content

Add type hints to scaling and rotation functions #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add type hints to scaling and rotation functions #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions mpl3d/glm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def ortho(left, right, bottom, top, znear, zfar):
return M


def scale(x=1, y=None, z=None):
def scale(x: float=1, y=None, z=None):
"""Non-uniform scaling along the x, y, and z axes

Parameters
Expand All @@ -137,7 +137,7 @@ def scale(x=1, y=None, z=None):
[0, 0, 0, 1]], dtype=float)


def translate(x=0, y=0, z=0):
def translate(x:float=0, y:float=0, z:float=0):
"""
Translate by an offset (x, y, z) .

Expand All @@ -161,7 +161,7 @@ def translate(x=0, y=0, z=0):
[0, 0, 0, 1]], dtype=float)


def xrotate(theta=0):
def xrotate(theta:float=0):
"""Rotation about the X axis

Parameters
Expand All @@ -181,7 +181,7 @@ def xrotate(theta=0):
[0, s, c, 0],
[0, 0, 0, 1]], dtype=float)

def yrotate(theta=0):
def yrotate(theta:float=0):
"""Rotation about the Y axis

Parameters
Expand All @@ -201,7 +201,7 @@ def yrotate(theta=0):
[-s, 0, c, 0],
[ 0, 0, 0, 1]], dtype=float)

def zrotate(theta=0):
def zrotate(theta:float=0):
"""Rotation about the Z axis

Parameters
Expand Down