Add type hints to scaling and rotation functions #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `float` type hinting, without it, the type hint is assume to be a `int`. In var=0, `0` is integer so it got confused
|
Not sure to see where it is necessary. |
|
pylance/pyright will detect the following as an error. matrix.xrotate(10.0)because the user is using a float when the function expect a |
|
There will be an implicit conversion anyway. But I agree with the fix. My only problem would be to make the fix on gsp directly. This code is kind of legacy and the new glm might deserve type hinting. |
|
@rougier this PR is on repo https://github.com/rougier/matplotlib-3d . This is unrelated to current GSP code if you agree with the fix, can you merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
floattype hinting, without it, the type hint is assume to be aint. In var=0,0is integer so it got confused