Skip to content

skip history and depth check for rmw_connextdds. #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

skip history and depth check for rmw_connextdds. #1064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions ros2cli/test/test_ros2cli_daemon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
import rclpy
import rclpy.action

from rclpy.utilities import get_rmw_implementation_identifier

from ros2cli.node.daemon import DaemonNode
from ros2cli.node.daemon import is_daemon_running
from ros2cli.node.daemon import shutdown_daemon
Expand Down Expand Up @@ -214,8 +216,11 @@ def test_get_publishers_info_by_topic(daemon_node):
TEST_TOPIC_PUBLISHER_QOS.durability
assert test_publisher_info.qos_profile.reliability == \
TEST_TOPIC_PUBLISHER_QOS.reliability
assert test_publisher_info.qos_profile.history == \
TEST_TOPIC_PUBLISHER_QOS.history
if get_rmw_implementation_identifier() != 'rmw_connextdds':
# rmw_connextdds does not collect the QoS history from discovery.
# See more details for https://github.com/ros2/ros2cli/issues/1054
assert test_publisher_info.qos_profile.history == \
TEST_TOPIC_PUBLISHER_QOS.history


def test_get_subscriptions_info_by_topic(daemon_node):
Expand All @@ -229,10 +234,13 @@ def test_get_subscriptions_info_by_topic(daemon_node):
TEST_TOPIC_SUBSCRIPTION_QOS.durability
assert test_subscription_info.qos_profile.reliability == \
TEST_TOPIC_SUBSCRIPTION_QOS.reliability
assert test_subscription_info.qos_profile.history == \
TEST_TOPIC_SUBSCRIPTION_QOS.history
assert test_subscription_info.qos_profile.depth == \
TEST_TOPIC_SUBSCRIPTION_QOS.depth
if get_rmw_implementation_identifier() != 'rmw_connextdds':
# rmw_connextdds does not collect the QoS history and depth from discovery
# See more details for https://github.com/ros2/ros2cli/issues/1054
assert test_subscription_info.qos_profile.history == \
TEST_TOPIC_SUBSCRIPTION_QOS.history
assert test_subscription_info.qos_profile.depth == \
TEST_TOPIC_SUBSCRIPTION_QOS.depth


def test_count_publishers(daemon_node):
Expand Down