Skip to content

Conversation

fujitatomoya
Copy link
Collaborator

Description

Temporary fix for #1061. (also part of #1054)

Is this user-facing behavior change?

No, it just skips a couple of test for QoS history and depth check via discovery process.

Did you use Generative AI?

No

Additional Information

Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fgallegosalido @lobolanja

what do you think we skip the test for rmw_connextdds until it finds out how to collect the QoS history and depth from discovery process? if RTI Connext DDS can support these tests, that would be the best without having this temporary patch.

@fgallegosalido
Copy link

I'm okay with disabling the tests for rmw_connextdds until we figure this out. Just make sure to add a TODO(fgallegosalido)or something similar to remind me that this should be enabled again.

@fujitatomoya
Copy link
Collaborator Author

@Mergifyio rebase

Copy link

mergify bot commented Jul 10, 2025

rebase

✅ Branch has been successfully rebased

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/issues-1061 branch from 5d59523 to 15a2f8c Compare July 10, 2025 18:16
@fujitatomoya
Copy link
Collaborator Author

Pulls: #1064
Gist: https://gist.githubusercontent.com/fujitatomoya/22ffbb144265182cea41b8bfa6351089/raw/1f60f022ea47942ffe27e3cc02c489c27090ff08/ros2.repos
BUILD args: --packages-above-and-dependencies ros2cli
TEST args: --packages-above ros2cli
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16455

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

https://ci.ros2.org/job/ci_linux-rhel/3693/ is unrelated.

i will hold this until at least one approval.

@fujitatomoya fujitatomoya self-assigned this Jul 10, 2025
@fujitatomoya fujitatomoya requested a review from mjcarroll July 10, 2025 21:34
@fujitatomoya
Copy link
Collaborator Author

@mjcarroll what do you think about this?

skipping connextdds QoS failure tests until RTI members figure out the solution to keep our CI stable.
probably we can close #1061 with this temporary fix, but i will keep #1054 to track this.

@Crola1702
Copy link
Contributor

@mjcarroll can you help us here with a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants