-
Notifications
You must be signed in to change notification settings - Fork 189
skip history and depth check for rmw_connextdds. #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolling
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think we skip the test for rmw_connextdds until it finds out how to collect the QoS history and depth from discovery process? if RTI Connext DDS can support these tests, that would be the best without having this temporary patch.
I'm okay with disabling the tests for rmw_connextdds until we figure this out. Just make sure to add a |
@Mergifyio rebase |
Signed-off-by: Tomoya Fujita <[email protected]>
✅ Branch has been successfully rebased |
5d59523
to
15a2f8c
Compare
Pulls: #1064 |
https://ci.ros2.org/job/ci_linux-rhel/3693/ is unrelated. i will hold this until at least one approval. |
@mjcarroll what do you think about this? skipping connextdds QoS failure tests until RTI members figure out the solution to keep our CI stable. |
@mjcarroll can you help us here with a review? |
Description
Temporary fix for #1061. (also part of #1054)
Is this user-facing behavior change?
No, it just skips a couple of test for QoS history and depth check via discovery process.
Did you use Generative AI?
No
Additional Information