Pull all example launchfiles into separate file with literalinclude
#5155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujitatomoya
approved these changes
Mar 24, 2025
mjcarroll
approved these changes
Mar 25, 2025
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
force-pushed
the
all-launch-examples-in-files
branch
from
df921bd to
11d6be1
Compare
christophebedard
approved these changes
Mar 25, 2025
|
Do you intend to backport this? It would be very painful, but it would avoid future merge conflicts when backporting. |
Signed-off-by: Emerson Knapp <[email protected]>
|
Ermmm, yeah I could do the backport to Humble and Jazzy. It's already been very painful lol |
christophebedard
approved these changes
Mar 26, 2025
Signed-off-by: Emerson Knapp <[email protected]>
|
We can merge it to rolling first though, and I can take the backports from there? I have some followup diffs I'd like to get started on. |
christophebedard
approved these changes
Mar 26, 2025
christophebedard
added
the
backport-all
|
Feel free to merge it if it's ready. I've added the backport-all label, let's just see how it goes. |
|
It is ready - I do not have merge access on this repository, I need you to press it for me :) |
mergify bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
…#5155) Signed-off-by: Emerson Knapp <[email protected]> (cherry picked from commit 666df3e) # Conflicts: # source/Tutorials/Intermediate/Launch/Using-Event-Handlers.rst # source/Tutorials/Intermediate/Launch/Using-Substitutions.rst
mergify bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
…#5155) Signed-off-by: Emerson Knapp <[email protected]> (cherry picked from commit 666df3e) # Conflicts: # source/How-To-Guides/Launch-file-different-formats.rst # source/Tutorials/Intermediate/Launch/Using-Event-Handlers.rst # source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst # source/Tutorials/Intermediate/Launch/Using-Substitutions.rst # source/Tutorials/Intermediate/Tf2/Adding-A-Frame-Cpp.rst # source/Tutorials/Intermediate/Tf2/Adding-A-Frame-Py.rst
christophebedard
pushed a commit
that referenced
this pull request
Mar 28, 2025
…nclude (backport #5155) (#5179) Signed-off-by: Emerson Knapp <[email protected]> (cherry picked from commit 666df3e) * Resolve merge conflicts
christophebedard
pushed a commit
that referenced
this pull request
Mar 28, 2025
…include (backport #5155) (#5183) Signed-off-by: Emerson Knapp <[email protected]> (cherry picked from commit 666df3e) * Fix up the rest of the tutorial launchfile merges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5143
This way we can easily grab them for testing, manipulate programmatically, share without repeating (especially in block-by-block code walkthroughs), and maybe even run linters on them at some point to apply ROS 2 coding standards and maintain a consistent formatting.
I resisted the temptation to rewrite them, except for minor formatting fixes.