[humble] Pull all example launchfiles into separate file with literalinclude (backport #5155) #5183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ros2#5155) Signed-off-by: Emerson Knapp <[email protected]> (cherry picked from commit 666df3e) # Conflicts: # source/How-To-Guides/Launch-file-different-formats.rst # source/Tutorials/Intermediate/Launch/Using-Event-Handlers.rst # source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst # source/Tutorials/Intermediate/Launch/Using-Substitutions.rst # source/Tutorials/Intermediate/Tf2/Adding-A-Frame-Cpp.rst # source/Tutorials/Intermediate/Tf2/Adding-A-Frame-Py.rst
|
@christophebedard for review, perhaps |
christophebedard
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #5175
Resolves conflicts in that branch - without write access I can't update the Mergify bot PR, so I've fixed it here instead.
Backports #5155 to humble
Part of #5143
This way we can easily grab them for testing, manipulate programmatically, share without repeating (especially in block-by-block code walkthroughs), and maybe even run linters on them at some point to apply ROS 2 coding standards and maintain a consistent formatting.
I resisted the temptation to rewrite them, except for minor formatting fixes.