This repository was archived by the owner on May 31, 2025. It is now read-only.
Closed
Conversation
rhaschke
force-pushed
the
sensor-parsing
branch
2 times, most recently
from
6967705 to
343783e
Compare
seanyen
referenced
this pull request
in seanyen/urdf
Jun 4, 2019
seanyen
referenced
this pull request
in seanyen/urdf
Jun 4, 2019
- crashes on exit: ros/class_loader#33 - on-demand-unloading works with ros/class_loader#34
Destroy class loader only after instances of parsers.
rhaschke
force-pushed
the
sensor-parsing
branch
from
343783e to
4e13137
Compare
Contributor
|
Thank you for the PR! Unfortunately I don't think we should merge this one. ROS Noetic will reach end-of-life on May 31st, 2025. Every change comes with a risk of introducing regressions, and there isn't much time left to fix them. I think the remaining time needs to be allocated towards bug fixes and compatibility with newer Ubuntu distros, so I'm closing pull requests that add features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebase of ros/robot_model#125 to this new, relocated repo.
The PR enables generic parsing of sensors from URDF. The idea is to extend sensor support beyond
CameraandRay, but to allow any custom sensor description with appropriate parsers provided via plugins. We use that mechanism for example to describe tactile sensors for our tactile toolbox. For a detailed motivation, please have a look at ros/urdfdom#84.This PR is only the very last in a whole series of PRs also involving ros/urdfdom_headers#22 and ros/urdfdom#84. Hence, it cannot compile without those.
Example usage can be seen in the unittest of tactile_toolbox.