Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated EntityCategory msg type with a new unknown type #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ayushgnv
Copy link

@ayushgnv ayushgnv commented Mar 31, 2025

It would helpful to have a default category (value of 0) to account for entities that dont exist so we can differentiate between a Generic object that exists vs one that is not found.

@ayushgnv
Copy link
Author

@adamdbrw any thoughts on this?

@adamdbrw
Copy link
Contributor

adamdbrw commented Apr 1, 2025

My idea with the OBJECT category was that it encompasses these cases (as in, everything is an object).
What would be a way in which we get entity returned by our APIs but this entity actually does not exist? Could you give me some context to that?

@ayushgnv
Copy link
Author

ayushgnv commented Apr 1, 2025

My idea with the OBJECT category was that it encompasses these cases (as in, everything is an object).

What would be a way in which we get entity returned by our APIs but this entity actually does not exist? Could you give me some context to that?

In GetEntityInfo, we return a result and EntityInfo. EntityInfo contains EntityCategory which can only be set as OBJECT and others. I think when a entity is not found rather than returning the default OBJECT with a error result, it would be cleaner for the user if EntityCategory had a field for UNKNOWN (or something similar) which is then returned with an error result.

@ayushgnv
Copy link
Author

ayushgnv commented Apr 1, 2025

@peci1 @azeey any thoughts regarding this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants