Skip to content

[CostmapTopicCollisionChecker] Alternative constructor with footprint string #4926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025

Conversation

doisyg
Copy link
Contributor

@doisyg doisyg commented Feb 17, 2025


Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on Ubuntu
Robotic platform tested on Dexory Robot
Does this PR contain AI generated software?

Description of contribution in a few bullet points

I needed to use the CostmapTopicCollisionChecker but with a custom footprint, NOT one served from a topic with FootprintSubscriber. So I added a constructor building a footpring from a string (same format as everywhere else).

Description of documentation updates required from your changes

Don't see any.

Description of how this change was tested

Dexory robot for a few days.


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski
Copy link
Member

All the system tests failed, so rerunning CI to see if that fixes it

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, just waiting to make sure CI passes that it wasn't just a fluke (but now I"m actually wondering if all the CI tests failed due to this issue I mention below)

Guillaume Doisy added 2 commits April 11, 2025 13:13
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...costmap_2d/src/costmap_topic_collision_checker.cpp 22.22% 7 Missing ⚠️
Files with missing lines Coverage Δ
...av2_costmap_2d/costmap_topic_collision_checker.hpp 100.00% <ø> (ø)
...costmap_2d/src/costmap_topic_collision_checker.cpp 76.31% <22.22%> (-17.24%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@doisyg doisyg requested a review from SteveMacenski April 12, 2025 10:38
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just need to error check and provided a more concise version of the sub check

Signed-off-by: Guillaume Doisy <[email protected]>
@doisyg
Copy link
Contributor Author

doisyg commented Apr 16, 2025

Tested at Dexory with the latest changes. Happy now.

@SteveMacenski SteveMacenski merged commit f8f1551 into ros-navigation:main Apr 16, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants