-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[CostmapTopicCollisionChecker] Alternative constructor with footprint string #4926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CostmapTopicCollisionChecker] Alternative constructor with footprint string #4926
Conversation
Signed-off-by: Guillaume Doisy <[email protected]>
All the system tests failed, so rerunning CI to see if that fixes it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, just waiting to make sure CI passes that it wasn't just a fluke (but now I"m actually wondering if all the CI tests failed due to this issue I mention below)
nav2_costmap_2d/include/nav2_costmap_2d/costmap_topic_collision_checker.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Guillaume Doisy <[email protected]>
Codecov ReportAttention: Patch coverage is
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just need to error check and provided a more concise version of the sub check
Signed-off-by: Guillaume Doisy <[email protected]>
Tested at Dexory with the latest changes. Happy now. |
Basic Info
Description of contribution in a few bullet points
I needed to use the
CostmapTopicCollisionChecker
but with a custom footprint, NOT one served from a topic withFootprintSubscriber
. So I added a constructor building a footpring from a string (same format as everywhere else).Description of documentation updates required from your changes
Don't see any.
Description of how this change was tested
Dexory robot for a few days.
Future work that may be required in bullet points
For Maintainers: