Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling ci with repos #2342

Closed
wants to merge 3 commits into from
Closed

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented May 17, 2021

#2339 without removing unreleased packages from repos.

@wep21 wep21 force-pushed the rolling-ci-with-repos branch from 3ec72a2 to 0db21f3 Compare May 17, 2021 10:51
@ruffsl
Copy link
Member

ruffsl commented May 17, 2021

#2339 without removing unreleased packages from repos.

Everything but ompl has indeed been released into rolling, no?

http://packages.ros.org/ros2/ubuntu/dists/focal/main/binary-amd64/Packages

The .repos file in #2339 does produce a building Dockerfile.

@SteveMacenski
Copy link
Member

SteveMacenski commented May 17, 2021

@ruffsl I agree that it looks like they're release, are we not calling rosdep in the right place now that the underlay workspace isn't needed for those? That is odd, maybe need to apt update?

I did a sampling and the 2 packages I looked into have built successfully in the build farm, so the binaries should be available

@ruffsl
Copy link
Member

ruffsl commented May 17, 2021

are we not calling rosdep in the right place now that the underlay workspace isn't needed for those? That is odd, maybe need to apt update?

Not sure what your asking. Are you asking if there are still unresolved dependencies? By commenting out the source repos of released rolling packages from the underlay's .repos file, the RUN directive invoking rosdep for the overlay workspaces will now instead be the layer where most of nav2's external dependencies will be installed.

@SteveMacenski
Copy link
Member

@wep21 I appreciate the PR and help, but I think Ruffin's got this one. He knows the CI system for nav2 the best of anyone and is underway.

@SteveMacenski
Copy link
Member

Closing - Ruffin's PR is merged and building, thanks for the help @wep21!

@ruffsl
Copy link
Member

ruffsl commented May 18, 2021

@wep21 , could you include 7d8afb2 in a new PR to fix linting. I'd like to see if CI is caching as expected after merging #2343 .

@wep21
Copy link
Contributor Author

wep21 commented May 18, 2021

@ruffsl Sure. #2346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants