Fail early for the resource conflicts between the activating controllers

[saikishor]

Fixes: #2758

@urfeex FYI

[bmagyar]

Pretty elegant, thank you!

[saikishor]

Pretty elegant, thank you!

I don't get the failing tests, I'll take a look when I get off the plane.

Thanks

[saikishor]

Sorry for the different committer naming, I did this from a colleagues laptop hahah

[codecov]

Codecov Report

❌ Patch coverage is 98.18182% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.65%. Comparing base (f53552b) to head (7b40d0a).

Files with missing lines	Patch %	Lines
controller_manager/src/controller_manager.cpp	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2760      +/-   ##
==========================================
+ Coverage   89.60%   89.65%   +0.04%     
==========================================
  Files         152      152              
  Lines       17637    17688      +51     
  Branches     1448     1449       +1     
==========================================
+ Hits        15804    15858      +54     
+ Misses       1250     1247       -3     
  Partials      583      583              

Flag	Coverage Δ
unittests	89.65% <98.18%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../include/controller_manager/controller_manager.hpp	97.29% <ø> (ø)
...ller_manager/test/test_controller_manager_srvs.cpp	99.34% <100.00%> (+0.02%)	⬆️
...ontroller_manager/test/test_release_interfaces.cpp	90.27% <ø> (ø)
controller_manager/src/controller_manager.cpp	77.22% <90.90%> (+0.23%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[urfeex]

Unfortunately, this does not fix #2758 for me. The output is the same as described in the issue.

[saikishor]

Unfortunately, this does not fix #2758 for me. The output is the same as described in the issue.

Thanks for commenting about it. I'll recheck the tests and try to run UR tests locally.