fix(agentos): route CompareVmConfig through the sidecar request loop - #2018
Merged
eersnington merged 1 commit intoSep 30, 2026
Conversation
This was referenced Sep 30, 2026
eersnington
force-pushed
the
stack/perf-agentos-chunked-sqlite-index-one-transaction-xnprllkk
branch
from
September 30, 2026 18:45
5d11641 to
2aac4f9
Compare
eersnington
force-pushed
the
stack/fix-agentos-route-compare-vm-config-mpwqyulr
branch
from
September 30, 2026 18:45
cc0e7d4 to
5dc8eb0
Compare
eersnington
force-pushed
the
stack/fix-agentos-route-compare-vm-config-mpwqyulr
branch
from
September 30, 2026 19:11
5dc8eb0 to
355d529
Compare
eersnington
force-pushed
the
stack/perf-agentos-chunked-sqlite-index-one-transaction-xnprllkk
branch
from
September 30, 2026 19:11
2aac4f9 to
9f59435
Compare
eersnington
force-pushed
the
stack/perf-agentos-chunked-sqlite-index-one-transaction-xnprllkk
branch
from
September 30, 2026 19:12
9f59435 to
140f2f0
Compare
eersnington
force-pushed
the
stack/fix-agentos-route-compare-vm-config-mpwqyulr
branch
from
September 30, 2026 19:12
355d529 to
128c2e1
Compare
eersnington
merged commit Sep 30, 2026
fbe0280
into
stack/perf-agentos-chunked-sqlite-index-one-transaction-xnprllkk
12 of 15 checks passed
eersnington
deleted the
stack/fix-agentos-route-compare-vm-config-mpwqyulr
branch
September 30, 2026 22:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompareVmConfigto decide whether a config change needs a VM restart.CreateVmandDisposeVmitself and sends every other request throughprepare_request_wire.CompareVmConfigwas not prepared there, so it failed withERR_AGENTOS_UNPREPARED_REQUEST_ROUTE. Every config change on a running VM failed.CompareVmConfigis now prepared likeListMounts.crates/client/tests/vm_config_compare_e2e.rs, which compares configs through a real sidecar.Code:
crates/native-sidecar/src/service.rsThis is part 4 of 4 in a stack: