Skip to content

fix(agentos): route CompareVmConfig through the sidecar request loop - #2018

Merged
eersnington merged 1 commit into
stack/perf-agentos-chunked-sqlite-index-one-transaction-xnprllkkfrom
stack/fix-agentos-route-compare-vm-config-mpwqyulr
Sep 30, 2026
Merged

eersnington merged 1 commit into
stack/perf-agentos-chunked-sqlite-index-one-transaction-xnprllkkfrom
stack/fix-agentos-route-compare-vm-config-mpwqyulr

Conversation

@eersnington

@eersnington eersnington commented Sep 30, 2026 •

Copy link
Copy Markdown
Member
  • Hosts call CompareVmConfig to decide whether a config change needs a VM restart.
  • The stdio request loop handles CreateVm and DisposeVm itself and sends every other request through prepare_request_wire. CompareVmConfig was not prepared there, so it failed with ERR_AGENTOS_UNPREPARED_REQUEST_ROUTE. Every config change on a running VM failed.
  • CompareVmConfig is now prepared like ListMounts.
  • Adds crates/client/tests/vm_config_compare_e2e.rs, which compares configs through a real sidecar.
RequestRoute::CompareVmConfig(payload) => {
    let result = self.compare_vm_config(&request, payload);
    Ok(Some(PreparedRequest::from_future(request, async move { result })))
}

Code: crates/native-sidecar/src/service.rs


This is part 4 of 4 in a stack:

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 1 medium-severity finding

Reviewed commit cc0e7d4.

Comment thread crates/client/tests/vm_config_compare_e2e.rs
@eersnington
eersnington force-pushed the stack/perf-agentos-chunked-sqlite-index-one-transaction-xnprllkk branch from 5d11641 to 2aac4f9 Compare September 30, 2026 18:45
@eersnington
eersnington force-pushed the stack/fix-agentos-route-compare-vm-config-mpwqyulr branch from cc0e7d4 to 5dc8eb0 Compare September 30, 2026 18:45

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues found

Reviewed commit 5dc8eb0.

@eersnington
eersnington force-pushed the stack/fix-agentos-route-compare-vm-config-mpwqyulr branch from 5dc8eb0 to 355d529 Compare September 30, 2026 19:11
@eersnington
eersnington force-pushed the stack/perf-agentos-chunked-sqlite-index-one-transaction-xnprllkk branch from 2aac4f9 to 9f59435 Compare September 30, 2026 19:11
@eersnington
eersnington force-pushed the stack/perf-agentos-chunked-sqlite-index-one-transaction-xnprllkk branch from 9f59435 to 140f2f0 Compare September 30, 2026 19:12
@eersnington
eersnington force-pushed the stack/fix-agentos-route-compare-vm-config-mpwqyulr branch from 355d529 to 128c2e1 Compare September 30, 2026 19:12
@eersnington
eersnington merged commit fbe0280 into stack/perf-agentos-chunked-sqlite-index-one-transaction-xnprllkk Sep 30, 2026
12 of 15 checks passed
@eersnington
eersnington deleted the stack/fix-agentos-route-compare-vm-config-mpwqyulr branch September 30, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant