Skip to content

fix(agentos): keep chunked_sqlite metadata pieces under the remote SQLite bind limit - #2016

Merged
eersnington merged 3 commits into
stack/fix-agentos-accept-bracket-command-name-wovpmrutfrom
stack/fix-agentos-chunked-sqlite-metadata-bind-limit-vwrkspxt
Sep 30, 2026
Merged

eersnington merged 3 commits into
stack/fix-agentos-accept-bracket-command-name-wovpmrutfrom
stack/fix-agentos-chunked-sqlite-metadata-bind-limit-vwrkspxt

Conversation

@eersnington

@eersnington eersnington commented Sep 30, 2026 •

Copy link
Copy Markdown
Member
  • chunked_sqlite saves its index (the file tree) as one byte array split into pieces, one INSERT per piece.
  • Remote actor SQLite rejects a statement whose bound values exceed 128 KiB. With 256 KiB pieces, every save failed once the index grew past 128 KiB.
  • Pieces are now 64 KiB. File chunk defaults are unchanged.
// before
const METADATA_CHUNK_SIZE: usize = 256 * 1024;
// after
const METADATA_CHUNK_SIZE: usize = 64 * 1024;

Code: crates/native-sidecar/src/plugins/chunked_sqlite.rs


This is part 2 of 4 in a stack:

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 1 high-severity finding

Reviewed commit b2215e7.

Comment thread crates/native-sidecar/src/plugins/chunked_sqlite.rs
@eersnington
eersnington merged commit 3a81572 into stack/fix-agentos-accept-bracket-command-name-wovpmrut Sep 30, 2026
8 checks passed
@eersnington
eersnington deleted the stack/fix-agentos-chunked-sqlite-metadata-bind-limit-vwrkspxt branch September 30, 2026 22:31

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues found

Reviewed commit 0d99114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant