Skip to content

Fix 'Practice later' button issue #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
coldenate wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix 'Practice later' button issue #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/widgets/funcs/checkNonCardSlide.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ import { QueueItemType } from '@remnote/plugin-sdk';

export function checkNonCardSlide(input: number | QueueItemType): boolean {
const cardSlides = new Set([1, 2, 3, 5]);
return !cardSlides.has(input);
const practiceLaterPage = 'PracticeLater';
return !cardSlides.has(input) && input !== practiceLaterPage;
}
10 changes: 6 additions & 4 deletions src/widgets/gamePadQueueHandler.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ function GamepadInput() {
);
const [isLookback, setIsLookback] = useState(false);
const [isNonCardSlide, setIsCardSlide] = useState(false);
const [isPracticeLaterPage, setIsPracticeLaterPage] = useState(false);
const getSessionStatus = async () => {
return await plugin.storage.getSession('settingsUiShown');
};
Expand Down Expand Up @@ -57,6 +58,7 @@ function GamepadInput() {
return;
}
setIsCardSlide(checkNonCardSlide(cardSlide!));
setIsPracticeLaterPage(cardSlide === 'PracticeLater');
};

const fetchLookback = async () => {
Expand Down Expand Up @@ -111,12 +113,12 @@ function GamepadInput() {
}
});
const showAnswer = async () => {
if (buttonReleased && !(await hasRevealedAnswer()) && !isLookback && !isNonCardSlide) {
if (buttonReleased && !(await hasRevealedAnswer()) && !isLookback && !isNonCardSlide && !isPracticeLaterPage) {
plugin.queue.showAnswer();
}
};
showAnswer();
}, [buttonReleased, isLookback, isNonCardSlide]);
}, [buttonReleased, isLookback, isNonCardSlide, isPracticeLaterPage]);

// Rate current card
useEffect(() => {
Expand All @@ -130,7 +132,7 @@ function GamepadInput() {
return;
}
const rateCard = async () => {
if (buttonReleased && ((await hasRevealedAnswer()) || isNonCardSlide)) {
if (buttonReleased && ((await hasRevealedAnswer()) || isNonCardSlide || isPracticeLaterPage)) {
logMessage(
plugin,
LogType.Info,
Expand All @@ -142,7 +144,7 @@ function GamepadInput() {
};
plugin.messaging.broadcast({ changeButtonCSS: null });
rateCard();
}, [buttonReleased, isNonCardSlide]);
}, [buttonReleased, isNonCardSlide, isPracticeLaterPage]);
return <div></div>;
}

Expand Down