Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added -q option to terminal page #96

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added -q option to terminal page #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9bd471
added -q option to CommandPage.vala to allow quiet execution (i.e., n…
PeterNaggschga Nov 21, 2024
66a7c42
added -q option to --help message
PeterNaggschga Nov 21, 2024
ceb3dbe
changed command execution from bash to nohup (part of coreutils)
PeterNaggschga Nov 24, 2024
b49f0f8
changed to not use nohup, but execute command directly (output is sho…
PeterNaggschga Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Application.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ namespace Ilia {
stdout.printf("\npages:\n");
stdout.printf("\t'apps' - launch desktop applications (default)\n");
stdout.printf("\t'terminal' - launch a terminal command\n");
stdout.printf("\t\t-q: quiet execution\n");
stdout.printf("\t'notifications' - launch notifications manager\n");
stdout.printf("\t'keybindings' - launch keybindings viewer\n");
stdout.printf("\t'textlist' - select an item from a specified list\n");
Expand Down
16 changes: 13 additions & 3 deletions src/commands/CommandPage.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ namespace Ilia {

private Gtk.TreePath path;

private bool quiet = false;

public string get_name() {
return "<u>C</u>ommands";
}
Expand Down Expand Up @@ -53,6 +55,9 @@ namespace Ilia {
this.entry = entry;
this.session_controller = sessionController;

if (arg_map.contains("-q"))
this.quiet = true;

model = new Gtk.ListStore(ITEM_VIEW_COLUMNS, typeof (string), typeof (string));

filter = new Gtk.TreeModelFilter(model, null);
Expand Down Expand Up @@ -219,9 +224,14 @@ namespace Ilia {
// TODO ~ Enable two launch modes with some modifier. By default terminal exits when program exits.
// todo is to add another mode in which the terminal does not exit after program completes.

// string commandline = "/usr/bin/x-terminal-emulator -e \"bash -c '" + cmd_path + "; exec bash'\"";
// string commandline = "x-terminal-emulator -e \"bash -c '" + cmd_path + "'\"";
string commandline = "x-terminal-emulator -e '" + cmd_path + "'";
string commandline;
if (this.quiet)
// if -q is given, call cmd_path without opening a terminal emulator
commandline = cmd_path;
else
// commandline = "/usr/bin/x-terminal-emulator -e \"bash -c '" + cmd_path + "; exec bash'\"";
// commandline = "x-terminal-emulator -e \"bash -c '" + cmd_path + "'\"";
commandline = "x-terminal-emulator -e '" + cmd_path + "'";

// stdout.printf("%s\n", commandline);

Expand Down