Added -q option to terminal page #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o x-terminal-emulator is started and output is discarded)
kgilmer
requested changes
Nov 23, 2024
There was a problem hiding this comment.
Generally looks good. I recall years back that execution style in ilia for term applications varied. I think at one point this (edit: launching the process in a hidden shell instance) was the default behavior but there was some edge case which caused the policy change. I don't recall the specifics though. Hoping there is a way we can achieve this without the hardcoded bash dependency..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses issue #70 by adding a
-qoption for the terminal page. When runningilia -p terminal -q, the selected command is executed, but nox-terminal-emulatoris opened, and the output is discarded.This mirrors the default behavior in i3 when executing commands via d-menu. It's useful in scenarios where the command's output isn't needed, and only its side effects are of interest.