Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: memory leak w/slow sources in parallel-merge and in write-to-stream #5

Merged
merged 5 commits into from
Jan 18, 2020
Merged

fix: memory leak w/slow sources in parallel-merge and in write-to-stream #5

merged 5 commits into from
Jan 18, 2020

Conversation

reconbot
Copy link
Owner

Works #4

@dko-slapdash can you test with your setup to see if this works?

@reconbot reconbot mentioned this pull request Jan 16, 2020
Closed
@reconbot
Copy link
Owner Author

Added a cleanup for writeToStream()

@reconbot reconbot changed the title fix: memory leak w/slow sources in parallel-merge fix: memory leak w/slow sources in parallel-merge and in write-to-stream Jan 17, 2020
@reconbot
Copy link
Owner Author

I made waitForQueue resolve early if there's data available. I don't think we'll ever hit that line but it's not expensive and the flow here is not as straightforward as I'd like.

@reconbot reconbot merged commit b5180bb into master Jan 18, 2020
@reconbot reconbot deleted the reconbot/race-to-the-memory-limit branch January 18, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reconbot @dko-slapdash