Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak issues with stalled streams and parallelMerge #4

Closed
reconbot opened this issue Jan 15, 2020 · 1 comment
Closed

Memory leak issues with stalled streams and parallelMerge #4

reconbot opened this issue Jan 15, 2020 · 1 comment

Comments

@reconbot
Copy link
Owner

From bustle/streaming-iterables#41 @dko-slapdash reported a issue with Promise.race() where even when the race promise resolves the callbacks it left on the unresolved promises are not garbage collected. This bug makes a lot of sense and I'm honestly not sure how to manage it in parallelMerge. I do notice we use Promise.race in fromStream and that one is avoidable.
reconbot added a commit that referenced this issue Jan 16, 2020
@reconbot
fix: memory leak w/slow sources in parallel-merge
5586634 
Works #4
@reconbot reconbot mentioned this issue Jan 16, 2020
Merged
@reconbot
Copy link
Owner Author

Figured out parallel-merge in #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reconbot