Fix ValueError from invalid CSS selectors in EmbedAPI #12573
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add defensive handling for invalid CSS selectors by wrapping css_first() calls in try-except blocks. This prevents crashes when malformed selectors like "@@R06GA" are passed via the maincontent parameter or fragment. Fixes: https://read-the-docs.sentry.io/issues/6923723755/
ericholscher
commented
Nov 12, 2025
| if selector: | ||
| return html.css_first(selector) | ||
| try: | ||
| return html.css_first(selector) |
Member
Author
There was a problem hiding this comment.
I do wonder if we should be allow listing the selectors we support here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds defensive handling for invalid CSS selectors in the EmbedAPI to prevent crashes.
Changes
Issue
Fixes: https://read-the-docs.sentry.io/issues/6923723755/
Previously, when malformed CSS selectors like
@@R06GAwere passed, selectolax would raise a ValueError that wasn't caught, causing the entire request to fail.