Skip to content

Conversation

rickhanlonii
Copy link
Member

Overview

Closes #4776 #7848

The "reset" button is weird.

Screenshot 2025-08-28 at 3 13 42 PM

When you click it, it alerts with "Do you want to reset your edits too"

  • Cancel - only reload
  • Ok - clear edits and reload

That would be fine I guess if we just relabeled the buttons, but when you're making edits, it's actually annoying to have to keep clicking "cancel".

So this PR separates the two into different buttons:

  • Reload: reload the iframe "page" (no confirmation)
  • Clear: clear all edits and reload (with confirmation)
Screen.Recording.2025-08-28.at.3.11.57.PM.mov

On mobile we'll now collapse to all icons:

Screenshot 2025-08-28 at 3 12 29 PM

@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference types="next/navigation-types/compat/navigation" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 127.98 KB (🟡 +41 B) 238.46 KB
/500 127.99 KB (🟡 +42 B) 238.47 KB
/[[...markdownPath]] 130.07 KB (🟡 +40 B) 240.56 KB
/errors 128.23 KB (🟡 +41 B) 238.71 KB
/errors/[errorCode] 128.21 KB (🟡 +41 B) 238.69 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@rickhanlonii rickhanlonii merged commit 2774ddf into reactjs:main Aug 29, 2025
8 checks passed
@rickhanlonii rickhanlonii deleted the rh/reset-button branch August 29, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[React Beta Docs] Reset Button
1 participant