fix: prevent partial reset when canceling reset confirmation. #7877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"[Bug]: "Reset state" on the playgrounds UX is confusing" was open in github issues and the user addressed the issue as the following: "The only way I found is clicking on "Reset", which triggers a popup saying "Reset all your edits too?" and then pressing "Cancel". This will successfully reset the state but not the code."
I looked into the issue and it was a minor bug where the refresh() is called even if the confirm is not true which is clicking on cancel.
`const handleReset = () => {
/**
* resetAllFiles must come first, otherwise
* the previous content will appear for a second
* when the iframe loads.
*
* Plus, it should only prompt if there's any file changes
*/
if (sandpack.editorState === 'dirty') {
const confirmed = confirm('Reset all your edits too?');
if (!confirmed) return;
sandpack.resetAllFiles();
}
};`
Now, it's all changed and the bug is fixed. Thank you : )