Skip to content

fix: prevent partial reset when canceling reset confirmation. #7877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vickrant-dev
Copy link

"[Bug]: "Reset state" on the playgrounds UX is confusing" was open in github issues and the user addressed the issue as the following: "The only way I found is clicking on "Reset", which triggers a popup saying "Reset all your edits too?" and then pressing "Cancel". This will successfully reset the state but not the code."

I looked into the issue and it was a minor bug where the refresh() is called even if the confirm is not true which is clicking on cancel.

`const handleReset = () => {
/**
* resetAllFiles must come first, otherwise
* the previous content will appear for a second
* when the iframe loads.
*
* Plus, it should only prompt if there's any file changes
*/
if (sandpack.editorState === 'dirty') {
const confirmed = confirm('Reset all your edits too?');
if (!confirmed) return;
sandpack.resetAllFiles();
}

refresh();

};`

Now, it's all changed and the bug is fixed. Thank you : )

Copy link

meta-cla bot commented Jul 17, 2025

Hi @vickrant-dev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@vickrant-dev vickrant-dev changed the title fix: prevent partial reset when canceling reset confirmation. Bug fix for #7848 fix: prevent partial reset when canceling reset confirmation. Jul 17, 2025
Copy link

github-actions bot commented Jul 17, 2025

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 110.45 KB (🟡 +2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@meta-cla meta-cla bot added the CLA Signed label Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant