[Data] Fixing incorrect assertion inside make_async_gen
#50210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Kudinkin <[email protected]>
Removed erroneous assertion Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
raulchen
reviewed
Feb 4, 2025
| # as worker-ids (so that for left workers sequences run out first) | ||
| target_length = worker_id + 1 | ||
|
|
||
| return iter([f"worker_{worker_id}:{i}" for i in range(target_length)]) |
There was a problem hiding this comment.
weird to add the _WorkerIterator only for tests.
Can we just use the fisrt item value to determine the target length?
Signed-off-by: Alexey Kudinkin <[email protected]>
raulchen
approved these changes
Feb 4, 2025
alexeykudinkin
added a commit
to alexeykudinkin/ray
that referenced
this pull request
Feb 10, 2025
…t#50210) This change addresses incorrect assertion implemented in `make_async_gen` enforcing that the sequences produced by the provided mappers are expected to produce sequences of the same lengths, which is not necessarily true. Added tests verifying this. --------- Signed-off-by: Alexey Kudinkin <[email protected]>
8 tasks
aslonnie
pushed a commit
that referenced
this pull request
Feb 10, 2025
Cherry-picking #50210 to 2.42.1 Signed-off-by: Alexey Kudinkin <[email protected]>
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Feb 13, 2025
…#50385) Cherry-picking ray-project#50210 to 2.42.1 Signed-off-by: Alexey Kudinkin <[email protected]>
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
…t#50210) This change addresses incorrect assertion implemented in `make_async_gen` enforcing that the sequences produced by the provided mappers are expected to produce sequences of the same lengths, which is not necessarily true. Added tests verifying this. --------- Signed-off-by: Alexey Kudinkin <[email protected]>
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
…t#50210) This change addresses incorrect assertion implemented in `make_async_gen` enforcing that the sequences produced by the provided mappers are expected to produce sequences of the same lengths, which is not necessarily true. Added tests verifying this. --------- Signed-off-by: Alexey Kudinkin <[email protected]>
park12sj
pushed a commit
to park12sj/ray
that referenced
this pull request
Mar 18, 2025
…t#50210) This change addresses incorrect assertion implemented in `make_async_gen` enforcing that the sequences produced by the provided mappers are expected to produce sequences of the same lengths, which is not necessarily true. Added tests verifying this. --------- Signed-off-by: Alexey Kudinkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This change addresses incorrect assertion implemented in
make_async_genenforcing that the sequences produced by the provided mappers are expected to produce sequences of the same lengths, which is not necessarily true.Added tests verifying this.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.