Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick] Cherry-picking #50210 to 2.42.1 #50385

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

alexeykudinkin
Copy link
Contributor

Why are these changes needed?

Cherry-picking #50210 to 2.42.1

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…t#50210)

This change addresses incorrect assertion implemented in
`make_async_gen` enforcing that the sequences produced by the provided
mappers are expected to produce sequences of the same lengths, which is
not necessarily true.

Added tests verifying this.

---------

Signed-off-by: Alexey Kudinkin <[email protected]>
@alexeykudinkin alexeykudinkin requested a review from a team as a code owner February 10, 2025 18:39
@alexeykudinkin alexeykudinkin added the go add ONLY when ready to merge, run all tests label Feb 10, 2025
@aslonnie
Copy link
Collaborator

a data test is failing:
https://buildkite.com/ray-project/premerge/builds/34428#0194f12a-3813-4d42-b371-470db7ff4008/184-1246

not sure if you want to have a look.

@alexeykudinkin
Copy link
Contributor Author

Test timing out that shouldn't run in parallel

@aslonnie aslonnie merged commit c2e38f7 into ray-project:releases/2.42.1 Feb 10, 2025
3 of 5 checks passed
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants