Skip to content

turbo frames lazy load support #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

turbo frames lazy load support #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/rails_charts/base_chart.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ def js_code
window.addEventListener('load', init_#{chart_id});
window.addEventListener('turbo:load', init_#{chart_id});
window.addEventListener('turbo:frame-load', init_#{chart_id});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will work like this, since we need to make sure that in case page has multiple turbo frames, we are not triggering this call for already rendered charts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umarana could you please check the comment above? It was a long time, but maybe you are still interested.

window.addEventListener('turbolinks:load', init_#{chart_id});
document.addEventListener("turbolinks:before-render", destroy_#{chart_id});
Expand Down Expand Up @@ -121,4 +122,4 @@ def y_axis
end

end
end
end