turbo frames lazy load support #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,6 +71,7 @@ def js_code | |||
|
|
|||
| window.addEventListener('load', init_#{chart_id}); | |||
| window.addEventListener('turbo:load', init_#{chart_id}); | |||
| window.addEventListener('turbo:frame-load', init_#{chart_id}); | |||
There was a problem hiding this comment.
I don't think it will work like this, since we need to make sure that in case page has multiple turbo frames, we are not triggering this call for already rendered charts.
There was a problem hiding this comment.
@umarana could you please check the comment above? It was a long time, but maybe you are still interested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.